Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 1187553005: Revert "Better messages for optimized index errors." (Closed)

Created:
5 years, 6 months ago by sra1
Modified:
5 years, 6 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Better messages for optimized index errors." TBR=lrn@google.com Committed: https://github.com/dart-lang/sdk/commit/82215d36f4f6163082d802508331e8b49b711b77

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -564 lines) Patch
M sdk/lib/_internal/compiler/js_lib/interceptors.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/js_lib/js_array.dart View 1 chunk +6 lines, -13 lines 0 comments Download
M sdk/lib/_internal/compiler/js_lib/js_helper.dart View 3 chunks +11 lines, -47 lines 0 comments Download
M sdk/lib/_internal/compiler/js_lib/js_string.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M sdk/lib/_internal/compiler/js_lib/native_typed_data.dart View 3 chunks +23 lines, -23 lines 0 comments Download
M sdk/lib/core/errors.dart View 1 chunk +1 line, -2 lines 0 comments Download
D tests/compiler/dart2js_extra/consistent_index_error_array_test.dart View 1 chunk +0 lines, -151 lines 0 comments Download
D tests/compiler/dart2js_extra/consistent_index_error_string_test.dart View 1 chunk +0 lines, -147 lines 0 comments Download
D tests/compiler/dart2js_extra/consistent_index_error_typed_list_test.dart View 1 chunk +0 lines, -159 lines 0 comments Download
M tests/lib/typed_data/typed_data_list_test.dart View 2 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sra1
Committed patchset #1 (id:1) manually as 82215d36f4f6163082d802508331e8b49b711b77 (presubmit successful).
5 years, 6 months ago (2015-06-12 23:53:32 UTC) #1
Lasse Reichstein Nielsen
LGTM. What failed?
5 years, 6 months ago (2015-06-13 09:07:22 UTC) #2
sra1
5 years, 6 months ago (2015-06-13 19:46:43 UTC) #3
Message was sent while issue was closed.
On 2015/06/13 09:07:22, Lasse Reichstein Nielsen wrote:
> LGTM. What failed?

I tweaked the handling for JavaScript RangeErrors and that was a bad idea for
the co19 tests.
I'll do that in a separate CL.

Powered by Google App Engine
This is Rietveld 408576698