Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 11875022: Fixing the DOM event streams test to work on FF and IE. (Closed)

Created:
7 years, 11 months ago by blois
Modified:
7 years, 11 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixing the DOM event streams test to work on FF and IE. I was using the focus event since it's supposed to be synchronous and it's nice to test with a browser-generated event for completeness, but it turns out the IE and FF<18 implement this as an async event (FF 18 appears to be correct). Just changed the test to manually trigger the event which is a fairly close approximation. BUG=7888 Committed: https://code.google.com/p/dart/source/detail?r=17102

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -19 lines) Patch
M tests/html/html.status View 3 chunks +0 lines, -3 lines 0 comments Download
M tests/html/streams_test.dart View 4 chunks +14 lines, -16 lines 2 comments Download

Messages

Total messages: 3 (0 generated)
blois
7 years, 11 months ago (2013-01-14 21:36:11 UTC) #1
Jennifer Messerly
lgtm https://codereview.chromium.org/11875022/diff/1/tests/html/streams_test.dart File tests/html/streams_test.dart (right): https://codereview.chromium.org/11875022/diff/1/tests/html/streams_test.dart#newcode20 tests/html/streams_test.dart:20: _a.$dom_dispatchEvent(event); is there a way to do this ...
7 years, 11 months ago (2013-01-14 21:56:51 UTC) #2
blois
7 years, 11 months ago (2013-01-14 22:00:05 UTC) #3
https://codereview.chromium.org/11875022/diff/1/tests/html/streams_test.dart
File tests/html/streams_test.dart (right):

https://codereview.chromium.org/11875022/diff/1/tests/html/streams_test.dart#...
tests/html/streams_test.dart:20: _a.$dom_dispatchEvent(event);
On 2013/01/14 21:56:51, John Messerly wrote:
> is there a way to do this without $dom_?

Currently it's on the old events API, but I need to either un-hide this method
or add it to EventStreamProvider. I used this method to keep it independent of
the old API, even though the old API cannot be removed until there's a proper
alternative for dispatching.

Powered by Google App Engine
This is Rietveld 408576698