Issue 11874003: Adding supported checks and flags to window.performance.

Issue 11874003: Adding supported checks and flags to window.performance. (Closed)

Created:
7 years, 11 months ago by blois

Modified:
7 years, 11 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Adding supported checks and flags to window.performance. BUG= Committed: https://code.google.com/p/dart/source/detail?r=16986

Patch Set 2 : Review feedback. #

Total comments: 1

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+81 lines, -102 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	1	16 chunks	+21 lines, -42 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		16 chunks	+23 lines, -42 lines	0 comments	Download
M	tests/html/html.status	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/html/performance_api_test.dart	View		1 chunk	+25 lines, -13 lines	0 comments	Download
M	tools/dom/scripts/generator.py	View		3 chunks	+8 lines, -0 lines	0 comments	Download
M	tools/dom/scripts/htmldartgenerator.py	View	1	1 chunk	+1 line, -3 lines	1 comment	Download
M	tools/dom/scripts/systemhtml.py	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

lgtm https://codereview.chromium.org/11874003/diff/1/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (right): https://codereview.chromium.org/11874003/diff/1/sdk/lib/html/dart2js/html_dart2js.dart#newcode15523 sdk/lib/html/dart2js/html_dart2js.dart:15523: * Checks if this type is supported on ...

7 years, 11 months ago (2013-01-11 21:16:12 UTC) #2

blois

https://codereview.chromium.org/11874003/diff/1/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (right): https://codereview.chromium.org/11874003/diff/1/sdk/lib/html/dart2js/html_dart2js.dart#newcode15523 sdk/lib/html/dart2js/html_dart2js.dart:15523: * Checks if this type is supported on the ...

7 years, 11 months ago (2013-01-11 21:28:02 UTC) #3

Emily Fortuna

lgtm https://codereview.chromium.org/11874003/diff/3002/tools/dom/scripts/htmldartgenerator.py File tools/dom/scripts/htmldartgenerator.py (right): https://codereview.chromium.org/11874003/diff/3002/tools/dom/scripts/htmldartgenerator.py#newcode36 tools/dom/scripts/htmldartgenerator.py:36: ' /// Checks if this type is supported ...

7 years, 11 months ago (2013-01-11 21:40:10 UTC) #4

blois

7 years, 11 months ago (2013-01-11 21:47:34 UTC) #5

Message was sent while issue was closed.

On 2013/01/11 21:40:10, Emily Fortuna wrote:
> lgtm
> 
>
https://codereview.chromium.org/11874003/diff/3002/tools/dom/scripts/htmldart...
> File tools/dom/scripts/htmldartgenerator.py (right):
> 
>
https://codereview.chromium.org/11874003/diff/3002/tools/dom/scripts/htmldart...
> tools/dom/scripts/htmldartgenerator.py:36: '  /// Checks if this type is
> supported on the current platform.\n'
> I know I suggested /** stuff */, but if you're going to do the /// I'd say
it's
> better to just do this:
> /**
>   * stuff
>   */
> 
> just so we're not mixing comment styles. :-)

I went with /// because it's actually a bit more consistent- all of the @domName
annotations are /// currently and the supported checks are normally surrounded
by those.

Expand Messages | Collapse Messages