Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11867024: Move some core classes to collection library. (Closed)

Created:
7 years, 11 months ago by floitsch
Modified:
7 years, 11 months ago
CC:
reviews_dartlang.org, Anders Johnsen
Visibility:
Public.

Description

Move some core classes to collection library. Committed: https://code.google.com/p/dart/source/detail?r=17352

Patch Set 1 #

Patch Set 2 : Minor library-name canges. #

Total comments: 2

Patch Set 3 : Add forgotten files. #

Total comments: 2

Patch Set 4 : Update status files with bug number. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+318 lines, -1078 lines) Patch
M editor/tools/plugins/com.google.dart.tools.core_test/test_data/Money/money.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M editor/util/debuggertest/pets.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/oauth2/test/utils.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/serialization/lib/serialization.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/unittest/lib/html_enhanced_config.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/io.dart View 1 chunk +1 line, -0 lines 0 comments Download
M samples/swarm/swarm_ui_lib/touch/touch.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart2js.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart2jslib.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/js_backend.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/mirrors/mirrors_util.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/native_handler.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/resolution.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/scanner/scannerlib.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/ssa.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/string_validator.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/tree/tree.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/types/types.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/collection/collection.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M sdk/lib/collection/collection_sources.gypi View 1 chunk +4 lines, -1 line 0 comments Download
A sdk/lib/collection/iterator.dart View 1 2 1 chunk +45 lines, -0 lines 0 comments Download
A + sdk/lib/collection/map.dart View 1 2 2 chunks +2 lines, -88 lines 0 comments Download
A + sdk/lib/collection/queue.dart View 1 chunk +1 line, -1 line 0 comments Download
A + sdk/lib/collection/set.dart View 1 2 1 chunk +2 lines, -55 lines 0 comments Download
M sdk/lib/core/core.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/core/corelib_sources.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/core/iterator.dart View 2 chunks +7 lines, -34 lines 0 comments Download
M sdk/lib/core/map.dart View 2 chunks +2 lines, -471 lines 0 comments Download
D sdk/lib/core/queue.dart View 1 chunk +0 lines, -319 lines 0 comments Download
M sdk/lib/core/set.dart View 1 chunk +0 lines, -104 lines 0 comments Download
M sdk/lib/io/io.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/co19/co19-compiler.status View 1 2 3 1 chunk +49 lines, -0 lines 0 comments Download
M tests/co19/co19-dart2dart.status View 1 2 3 1 chunk +45 lines, -0 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 2 3 1 chunk +42 lines, -0 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 2 3 2 chunks +44 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/compiler/dart2js_extra/type_argument_factory_crash_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/compiler/dart2js_extra/type_argument_factory_nocrash_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/corelib/collection_from_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/corelib/collection_test.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/corelib/collection_to_string_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/corelib/has_next_iterator_test.dart View 1 1 chunk +3 lines, -0 lines 0 comments Download
M tests/corelib/linked_hash_map_test.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tests/corelib/map_from_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/corelib/queue_first_test.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/corelib/queue_iterator_test.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/corelib/queue_last_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/corelib/queue_single_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/corelib/queue_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tools/testing/dart/test_runner.dart View 1 chunk +1 line, -0 lines 0 comments Download
M utils/pub/version_solver.dart View 1 chunk +1 line, -0 lines 0 comments Download
M utils/pub/yaml/yaml.dart View 1 chunk +1 line, -0 lines 0 comments Download
M utils/tests/pub/test_pub.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
floitsch
7 years, 11 months ago (2013-01-18 20:27:08 UTC) #1
floitsch
Added forgotten files.
7 years, 11 months ago (2013-01-21 08:53:51 UTC) #2
Lasse Reichstein Nielsen
lgtm https://codereview.chromium.org/11867024/diff/2001/sdk/lib/_internal/compiler/implementation/dart2js.dart File sdk/lib/_internal/compiler/implementation/dart2js.dart (right): https://codereview.chromium.org/11867024/diff/2001/sdk/lib/_internal/compiler/implementation/dart2js.dart#newcode8 sdk/lib/_internal/compiler/implementation/dart2js.dart:8: import 'dart:collection' show Queue, LinkedHashMap; Why the "show"? ...
7 years, 11 months ago (2013-01-21 08:55:49 UTC) #3
floitsch
7 years, 11 months ago (2013-01-21 10:40:10 UTC) #4 
https://codereview.chromium.org/11867024/diff/2001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/dart2js.dart (right):

https://codereview.chromium.org/11867024/diff/2001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/dart2js.dart:8: import
'dart:collection' show Queue, LinkedHashMap;
On 2013/01/21 08:55:49, Lasse Reichstein Nielsen wrote:
> Why the "show"? Is there a conflict?

I don't think so, but I didn't want to take the risk.

https://codereview.chromium.org/11867024/diff/4001/tests/co19/co19-compiler.s...
File tests/co19/co19-compiler.status (right):

https://codereview.chromium.org/11867024/diff/4001/tests/co19/co19-compiler.s...
tests/co19/co19-compiler.status:435:
Language/14_Types/4_Interface_Types_A08_t06: Fail # Moved collection classes
from core to collection. TODO(floitsch): create co19 bug.
On 2013/01/21 08:55:49, Lasse Reichstein Nielsen wrote:
> Create the error before committing and update with the number.

Done.

Powered by Google App Engine
This is Rietveld 408576698