Issue 11867022: Transition ^= to |=

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11867022: Transition ^= to |= (Closed)

Created:
7 years, 11 months ago by srdjan

Modified:
7 years, 11 months ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Transition ^= to |= Committed: https://code.google.com/p/dart/source/detail?r=17309

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -41 lines)			Patch
M	runtime/vm/bigint_operations.cc	View	7 chunks	+14 lines, -14 lines	0 comments	Download
M	runtime/vm/cha.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/code_generator_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/code_patcher_ia32.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/code_patcher_x64.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/dart.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	7 chunks	+7 lines, -7 lines	0 comments	Download
M	runtime/vm/dart_entry.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/debugger_api_impl.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/exceptions.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/resolver.cc	View	2 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM We could try to rename operator= to find all occurrences that can be optimized.

7 years, 11 months ago (2013-01-18 19:02:11 UTC) #2

srdjan

7 years, 11 months ago (2013-01-18 19:12:08 UTC) #3

On 2013/01/18 19:02:11, regis wrote:
> LGTM
> 
> We could try to rename operator= to find all occurrences that can be
optimized.

Yes, need to catch those as well.

Expand Messages | Collapse Messages