Issue 1186503003: Wrap program into (function(){ <prog> })() instead of !function...().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1186503003: Wrap program into (function(){ <prog> })() instead of !function...(). (Closed)

Created:
5 years, 6 months ago by floitsch

Modified:
5 years, 6 months ago

Reviewers:
herhut

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Wrap program into (function(){ <prog> })() instead of !function...(). V8 is much faster with the parenthesis (*5). R=herhut@google.com Committed: https://github.com/dart-lang/sdk/commit/93c9fc6faea2f7c27ec8ec2bdbd38e7c5791681a

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

floitsch

5 years, 6 months ago (2015-06-18 09:34:39 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
93c9fc6faea2f7c27ec8ec2bdbd38e7c5791681a (presubmit successful).