Issue 11865010: Simplification: avoid boxing/unboxing of ClassElements in ClassBaseTypes. This makes things shorter…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11865010: Simplification: avoid boxing/unboxing of ClassElements in ClassBaseTypes. This makes things shorter… (Closed)

Created:
7 years, 11 months ago by polux

Modified:
7 years, 11 months ago

Reviewers:
karlklose

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Simplification: avoid boxing/unboxing of ClassElements in ClassBaseTypes. This makes things shorter, faster, and ensures by typing that only classes are passed to functions that expect classes. Committed: https://code.google.com/p/dart/source/detail?r=17184

Patch Set 1 #

Total comments: 2

Patch Set 2 : classElem(ens) -> cls #

Patch Set 3 : sync to head #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -37 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart	View	1	16 chunks	+34 lines, -37 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

karlklose

LGTM. https://codereview.chromium.org/11865010/diff/1/sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart File sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart (right): https://codereview.chromium.org/11865010/diff/1/sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart#newcode1088 sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart:1088: Element classElem = member.getEnclosingClass(); 'classElem' -> 'classElement' (or ...

7 years, 11 months ago (2013-01-15 09:56:40 UTC) #2

polux

7 years, 11 months ago (2013-01-17 09:52:47 UTC) #3

https://codereview.chromium.org/11865010/diff/1/sdk/lib/_internal/compiler/im...
File
sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart
(right):

https://codereview.chromium.org/11865010/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart:1088:
Element classElem = member.getEnclosingClass();
On 2013/01/15 09:56:40, karlklose wrote:
> 'classElem' -> 'classElement' (or even 'cls')?

Done everywhere for consistency.

Expand Messages | Collapse Messages