Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Issue 1186353004: Move allocation of static API handles Dart_True, etc. (Closed)

Created:
5 years, 6 months ago by koda
Modified:
5 years, 6 months ago
Reviewers:
siva, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Ivan Posva
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move allocation of static API handles Dart_True, etc. Instead of an unbalanced local scope, allocate them alongside the corresponding static VM handles. BUG= R=iposva@google.com Committed: https://github.com/dart-lang/sdk/commit/9a5dc19140022f5414fc68c4aef0a41dc0eb65a1

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add LocalHandle::apiHandle #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -9 lines) Patch
M runtime/vm/dart.h View 2 chunks +3 lines, -0 lines 0 comments Download
M runtime/vm/dart.cc View 3 chunks +10 lines, -4 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 2 chunks +14 lines, -5 lines 0 comments Download
M runtime/vm/dart_api_state.h View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
koda
5 years, 6 months ago (2015-06-17 15:00:26 UTC) #2
Ivan Posva
LGTM -ip https://codereview.chromium.org/1186353004/diff/1/runtime/vm/dart_api_impl.cc File runtime/vm/dart_api_impl.cc (right): https://codereview.chromium.org/1186353004/diff/1/runtime/vm/dart_api_impl.cc#newcode500 runtime/vm/dart_api_impl.cc:500: return reinterpret_cast<Dart_Handle>(ref); Not sure how often we ...
5 years, 6 months ago (2015-06-17 16:58:57 UTC) #4
koda
On 2015/06/17 16:58:57, Ivan Posva wrote: > LGTM -ip > > https://codereview.chromium.org/1186353004/diff/1/runtime/vm/dart_api_impl.cc > File runtime/vm/dart_api_impl.cc ...
5 years, 6 months ago (2015-06-17 19:45:06 UTC) #5
koda
5 years, 6 months ago (2015-06-17 19:46:40 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
9a5dc19140022f5414fc68c4aef0a41dc0eb65a1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698