Issue 11862008: Make Streams also cosider a thrown AsyncError a rethrow.

Issue 11862008: Make Streams also cosider a thrown AsyncError a rethrow. (Closed)

Created:
7 years, 11 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 11 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make Streams also cosider a thrown AsyncError a rethrow. Also change handleError to be based on throws for errors. Committed: https://code.google.com/p/dart/source/detail?r=16973

Patch Set 2 : Fix indentation. #

Total comments: 8

Patch Set 3 : Address reciew comments. #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+236 lines, -109 lines)			Patch
M	sdk/lib/async/stream.dart	View	1 2	12 chunks	+103 lines, -83 lines	0 comments	Download
M	sdk/lib/async/stream_controller.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	sdk/lib/async/stream_impl.dart	View		3 chunks	+6 lines, -0 lines	0 comments	Download
M	sdk/lib/async/stream_pipe.dart	View	1 2	15 chunks	+69 lines, -22 lines	0 comments	Download
M	tests/lib/async/stream_controller_async_test.dart	View	1	1 chunk	+52 lines, -0 lines	0 comments	Download
M	tests/lib/async/stream_controller_test.dart	View		4 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://codereview.chromium.org/11862008/diff/2001/sdk/lib/async/stream.dart File sdk/lib/async/stream.dart (right): https://codereview.chromium.org/11862008/diff/2001/sdk/lib/async/stream.dart#newcode117 sdk/lib/async/stream.dart:117: * true. If [test] is omitted, evert error ...

7 years, 11 months ago (2013-01-11 13:23:33 UTC) #2

Lasse Reichstein Nielsen

7 years, 11 months ago (2013-01-14 08:33:30 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/11862008/diff/2001/sdk/lib/async/stream.dart
File sdk/lib/async/stream.dart (right):

https://codereview.chromium.org/11862008/diff/2001/sdk/lib/async/stream.dart#...
sdk/lib/async/stream.dart:117: * true. If [test] is omitted, evert error is
considered mathcing.
On 2013/01/11 13:23:33, floitsch wrote:
> every ... matching

Done.

https://codereview.chromium.org/11862008/diff/2001/sdk/lib/async/stream.dart#...
sdk/lib/async/stream.dart:214: } on AsyncError catch (e) {
Done.

It's not pretty, but it's a little smaller and less boilerplate.

https://codereview.chromium.org/11862008/diff/2001/sdk/lib/async/stream.dart#...
sdk/lib/async/stream.dart:774: if (0 > index) throw new ArgumentError(index);
On 2013/01/11 13:23:33, floitsch wrote:
> No. If you don't want to check for int, don't check, but don't invert the
order.

Done.

https://codereview.chromium.org/11862008/diff/2001/sdk/lib/async/stream_pipe....
File sdk/lib/async/stream_pipe.dart (right):

https://codereview.chromium.org/11862008/diff/2001/sdk/lib/async/stream_pipe....
sdk/lib/async/stream_pipe.dart:174: final _ErrorTransformation _transform;
On 2013/01/11 13:23:33, floitsch wrote:
> Type is not right anymore. It's a void function now.

Done.

Expand Messages | Collapse Messages