Issue 11861007: Move indexSet and unary operators to the new interceptor mechanism.

Issue 11861007: Move indexSet and unary operators to the new interceptor mechanism. (Closed)

Created:
7 years, 11 months ago by ngeoffray

Modified:
7 years, 11 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Move indexSet and unary operators to the new interceptor mechanism. Committed: https://code.google.com/p/dart/source/detail?r=17051

Patch Set 2 : #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+174 lines, -262 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/constant_system.dart	View	1	2 chunks	+8 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/constant_system_dart.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/js_array.dart	View		2 chunks	+8 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/js_helper.dart	View		2 chunks	+0 lines, -74 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/js_number.dart	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View	1	4 chunks	+39 lines, -52 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/codegen.dart	View		2 chunks	+10 lines, -18 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/nodes.dart	View		7 chunks	+69 lines, -101 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/optimize.dart	View	1	3 chunks	+19 lines, -11 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/tracer.dart	View		3 chunks	+14 lines, -3 lines	0 comments	Download
M	tests/compiler/dart2js/mock_compiler.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

https://codereview.chromium.org/11861007/diff/7001/sdk/lib/_internal/compiler/implementation/ssa/nodes.dart File sdk/lib/_internal/compiler/implementation/ssa/nodes.dart (right): https://codereview.chromium.org/11861007/diff/7001/sdk/lib/_internal/compiler/implementation/ssa/nodes.dart#newcode1339 sdk/lib/_internal/compiler/implementation/ssa/nodes.dart:1339: // TODO(ngeoffray): Move this logic into a different class ...

7 years, 11 months ago (2013-01-14 15:07:14 UTC) #1

kasperl

LGTM. https://codereview.chromium.org/11861007/diff/7001/sdk/lib/_internal/compiler/implementation/ssa/builder.dart File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right): https://codereview.chromium.org/11861007/diff/7001/sdk/lib/_internal/compiler/implementation/ssa/builder.dart#newcode2307 sdk/lib/_internal/compiler/implementation/ssa/builder.dart:2307: case '-': operation = constantSystem.negate; break; Maybe this ...

7 years, 11 months ago (2013-01-15 07:06:12 UTC) #2

ngeoffray

7 years, 11 months ago (2013-01-15 08:56:09 UTC) #3

Thanks Kasper

https://codereview.chromium.org/11861007/diff/7001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right):

https://codereview.chromium.org/11861007/diff/7001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:2307: case '-':
operation = constantSystem.negate; break;
On 2013/01/15 07:06:12, kasperl wrote:
> Maybe this code would be nicer to have on the constant system? Something like
a
> lookupUnary('-')? The switch feels a little bit misplaced here.

Done.

https://codereview.chromium.org/11861007/diff/7001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:2324: =
buildInvokeDynamic(node, elements.getSelector(node), operand, []);
On 2013/01/15 07:06:12, kasperl wrote:
> We usually put = on the previous line.

Done.

https://codereview.chromium.org/11861007/diff/7001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (right):

https://codereview.chromium.org/11861007/diff/7001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/codegen.dart:2147: push(new
js.Assignment(new js.PropertyAccess(receiver, index), pop()),
On 2013/01/15 07:06:12, kasperl wrote:
> Fits on one line now?

No.

Expand Messages | Collapse Messages