Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 1186033004: Update analyzer to reflect new rules for prefixes. (Closed)

Created:
5 years, 6 months ago by Paul Berry
Modified:
5 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org, Siggi Cherem (dart-lang), hausner
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update analyzer to reflect new rules for prefixes. As of commit 67b99e4b33023ecf162148fb8400da8839d73065, it is now consistently a compile error for a prefix not to be followed by '.'. (Previously, there were two exceptions in which a prefix not followed by '.' was treated as though it was preceded by "this.") This CL updates analyzer to be consistent with the new spec langauge, and modifies the tests in tests/language accordingly. Dart2js and the VM do not yet produce the correct compile-time error in all circumstances. See issues #23611 and #23612. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/9c90a66d0d9f2dd6f3e7cd831f2a3e15ddeb8603

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -195 lines) Patch
M pkg/analyzer/lib/src/generated/element_resolver.dart View 4 chunks +7 lines, -13 lines 0 comments Download
M pkg/analyzer/test/generated/compile_time_error_code_test.dart View 2 chunks +90 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/non_error_resolver_test.dart View 2 chunks +0 lines, -44 lines 0 comments Download
M pkg/analyzer/test/generated/static_type_warning_code_test.dart View 3 chunks +0 lines, -90 lines 0 comments Download
M tests/language/illegal_invocation_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/language.status View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/language/prefix_assignment_test.dart View 2 chunks +3 lines, -23 lines 0 comments Download
M tests/language/prefix_unqualified_invocation_test.dart View 1 chunk +7 lines, -23 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 6 months ago (2015-06-17 21:50:24 UTC) #2
Brian Wilkerson
LGTM
5 years, 6 months ago (2015-06-17 22:20:45 UTC) #3
Paul Berry
5 years, 6 months ago (2015-06-18 17:03:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9c90a66d0d9f2dd6f3e7cd831f2a3e15ddeb8603 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698