Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issue 118603002: Keep track of current "pause" event in the debugger. (Closed)

Created:
7 years ago by turnidge
Modified:
7 years ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Keep track of current "pause" event in the debugger. This will allow us (later) to make nice descriptions of the state of an isolate, e.g. "isolate 7112 is paused due to breakpoint 2" or "isolate 7112 is paused due to interrupt" or "isolate 7112 is running". Use a new Pause() function to call the event handler during a pause. It does some shared checking, setup, teardown. Minor change in isolate interrupt handling - before we were not setting 'in_event_handler_' in this case. Now we set 'pause_event_' here, which will guard against recursive pauses in this case. Reviewer: not sure what I think about all the names I used here. "pause_event_" is very similar to PausedEvent but means something different, as it includes pauses, interrupts, and (maybe) exceptions. Dunno. R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=31356

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -39 lines) Patch
M runtime/vm/debugger.h View 4 chunks +23 lines, -7 lines 0 comments Download
M runtime/vm/debugger.cc View 10 chunks +29 lines, -25 lines 0 comments Download
M runtime/vm/debugger_test.cc View 1 2 2 chunks +59 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
turnidge
https://codereview.chromium.org/118603002/diff/1/runtime/vm/debugger.cc File runtime/vm/debugger.cc (right): https://codereview.chromium.org/118603002/diff/1/runtime/vm/debugger.cc#newcode191 runtime/vm/debugger.cc:191: ASSERT(debugger->stack_trace_ == NULL); in_event_handler_ was missing here before. I ...
7 years ago (2013-12-18 21:27:58 UTC) #1
turnidge
Oops, forgot to add the reviewer... Matthias, you're it.
7 years ago (2013-12-18 21:38:19 UTC) #2
hausner
lgtm
7 years ago (2013-12-18 22:56:10 UTC) #3
turnidge
7 years ago (2013-12-20 22:30:28 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r31356 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698