Stop passing library elements to tons of namer functions.

Stop passing library elements to tons of namer functions.

Whenever we have to "invent" a library reference there's a
good chance that we get it wrong (because of inlining, etc.)
which messes up our privacy implementation.

Committed: https://code.google.com/p/dart/source/detail?r=16963

[kasperl, 2013-01-11 10:15:41]

Feel free to ignore this for now. It's based on another CL and I messed up the
uploading of the diff.

[kasperl, 2013-01-11 10:18:27]

Ready for review.

[ngeoffray, 2013-01-11 10:29:11]

LGTM!

https://codereview.chromium.org/11860008/diff/4001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/js_backend/namer.dart (right):

https://codereview.chromium.org/11860008/diff/4001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/js_backend/namer.dart:148: return
'_library$libraryName\$$nameString';
Note that you just changed the name to start with 'library' instead of 'lib'.

https://codereview.chromium.org/11860008/diff/4001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/js_backend/namer.dart:201: // is
generated in by string concatenation applyFunction from
in by string concatenation applyFunction -> by string concatenation in
applyFunction.

[erikcorry, 2013-01-15 13:11:34]

Unfortunately, this broke minified mode.  It was already a little broken with 3
failing tests, but with this change there are 66 failing tests with the
following:

./tools/test.py -mrelease -cdart2js -rd8 --use-sdk --time -pcolor --report
dart2js_extra dart2js_native --minified

The issue is that the minifier is not allowed to rename call$0, call$1, etc.
because they are generated programattically from 'call' and an integer.  With
this change the call$1 selector is renamed at the call site, but not at the
definition site.

[kasperl, 2013-01-15 13:19:17]

Thanks for the update, Erik. I'll try to fix that.

[kasperl, 2013-01-15 14:25:45]

Fix uploaded in https://codereview.chromium.org/11893003/. Even with this fix I
still see ~7 failures.