Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1185983005: Introduce dart_tools_api.h (Closed)

Created:
5 years, 6 months ago by Cutch
Modified:
5 years, 6 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Introduce dart_tools_api.h - Move contents of dart_debugger_api.h into dart_tools_api.h - Make dart_debugger_api.h forward to dart_tools_api.h - Move some (service, timeline) bits of dart_api.h into dart_tools_api.h. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/075ac55eb3e8fae87471b788bba883e960c33a9b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -855 lines) Patch
M runtime/bin/dartutils.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/include/dart_api.h View 1 chunk +0 lines, -134 lines 0 comments Download
M runtime/include/dart_debugger_api.h View 1 chunk +3 lines, -715 lines 0 comments Download
A + runtime/include/dart_tools_api.h View 4 chunks +171 lines, -5 lines 0 comments Download
M runtime/vm/service.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Cutch
5 years, 6 months ago (2015-06-16 20:14:54 UTC) #2
siva
lgtm
5 years, 6 months ago (2015-06-17 15:30:36 UTC) #3
Cutch
5 years, 6 months ago (2015-06-17 16:45:41 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
075ac55eb3e8fae87471b788bba883e960c33a9b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698