Issue 11859034: Add mips and simmips build targets.

Issue 11859034: Add mips and simmips build targets. (Closed)

Created:
7 years, 11 months ago by regis

Modified:
7 years, 11 months ago

Reviewers:
siva, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add mips and simmips build targets. Committed: https://code.google.com/p/dart/source/detail?r=17319

Patch Set 2 : #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -5 lines)			Patch
M	runtime/platform/globals.h	View	1	3 chunks	+11 lines, -2 lines	0 comments	Download
M	tools/build.py	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tools/gyp/configurations.gypi	View	1	3 chunks	+42 lines, -0 lines	0 comments	Download
M	tools/gyp/configurations_make.gypi	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download
M	tools/testing/dart/test_options.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

siva

LGTM with one question regarding ReleaseSIMMIPS and ReleaseSIMARM https://chromiumcodereview.appspot.com/11859034/diff/1/tools/gyp/configurations.gypi File tools/gyp/configurations.gypi (right): https://chromiumcodereview.appspot.com/11859034/diff/1/tools/gyp/configurations.gypi#newcode143 tools/gyp/configurations.gypi:143: # ...

7 years, 11 months ago (2013-01-18 20:59:26 UTC) #3

regis

Thanks https://chromiumcodereview.appspot.com/11859034/diff/1/tools/gyp/configurations.gypi File tools/gyp/configurations.gypi (right): https://chromiumcodereview.appspot.com/11859034/diff/1/tools/gyp/configurations.gypi#newcode143 tools/gyp/configurations.gypi:143: # Should not inherit from Dart_Release (see DebugSIMMIPS). ...

7 years, 11 months ago (2013-01-18 21:34:32 UTC) #4

regis

7 years, 11 months ago (2013-01-18 21:42:04 UTC) #5

Message was sent while issue was closed.

On 2013/01/18 21:34:32, regis wrote:
> Thanks
> 
>
https://chromiumcodereview.appspot.com/11859034/diff/1/tools/gyp/configuratio...
> File tools/gyp/configurations.gypi (right):
> 
>
https://chromiumcodereview.appspot.com/11859034/diff/1/tools/gyp/configuratio...
> tools/gyp/configurations.gypi:143: # Should not inherit from Dart_Release (see
> DebugSIMMIPS).
> On 2013/01/18 20:59:26, siva wrote:
> > Not clear why this restriction is needed, maybe we should remove it and try
> > (both here and the in ReleaseSIMARM).
> 
> Good point. Removed for ReleaseSIMMIPS and ReleaseSIMARM. We can revisit when
we
> actually build the simulators.

I submitted before saving the change. It will be included in my next cl.

Expand Messages | Collapse Messages