Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 11859031: Add a library tag to allow running on DRT. (Closed)

Created:
7 years, 11 months ago by Anton Muhin
Modified:
7 years, 11 months ago
Reviewers:
ahe, ngeoffray
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add a library tag to allow running on DRT. R=ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=17280

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tests/language/private4_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Anton Muhin
7 years, 11 months ago (2013-01-18 14:30:17 UTC) #1
ngeoffray
LGTM, thanks Anton.
7 years, 11 months ago (2013-01-18 14:35:14 UTC) #2
ahe
7 years, 11 months ago (2013-01-18 15:01:31 UTC) #3
Message was sent while issue was closed.
Please don't change correct tests to work around bug 2264.

This would not be a problem if DRT could run the tests directly instead of
relying on a wrapping hack.

Powered by Google App Engine
This is Rietveld 408576698