Issue 11855007: Optimize stores to Uint8List.

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+171 lines, -93 lines)			Patch
M	runtime/vm/flow_graph_optimizer.cc	View	1 2 3 4	3 chunks	+34 lines, -17 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 2	2 chunks	+64 lines, -37 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1	2 chunks	+66 lines, -38 lines	0 comments	Download
M	runtime/vm/locations.h	View		1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

srdjan

Do you plan to do it for int32 and uint16 typed arrays? Slava had performance ...

7 years, 11 months ago (2013-01-11 17:02:37 UTC) #3

Florian Schneider

7 years, 11 months ago (2013-01-14 10:03:10 UTC) #5

Yes, I definitely plan to do it for all the missing array types: Uint8Clamped,
Int16/Uint16, Int32/Uint32.

Not sure yet, what to do with Uint64: we have unboxed int64, but uint64 is too
large.

https://codereview.chromium.org/11855007/diff/10001/runtime/vm/flow_graph_opt...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/11855007/diff/10001/runtime/vm/flow_graph_opt...
runtime/vm/flow_graph_optimizer.cc:613: ASSERT(value_type.IsDoubleType() ||
value_type.IsIntType());
On 2013/01/11 17:02:38, srdjan wrote:
> Maybe you want to split the ASSERT: double type is not allowed for Uint8 
array
> and int is not allowed for Float32.

Done.

Expand Messages | Collapse Messages