Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(940)

Issue 1185483004: Revert "Handle most qualified sends." (Closed)

Created:
5 years, 6 months ago by karlklose
Modified:
5 years, 6 months ago
Reviewers:
Johnni Winther, herhut
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Handle most qualified sends." This reverts commit ec40a1401993d97a01a7fa3001035b7206986796. TBR=herhut@google.com,johnniwinther@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/b01c4bd438357fc32cb00d69b4aa8a017f9dde1b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -351 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/access_semantics.dart View 2 chunks +0 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 7 chunks +30 lines, -216 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution_common.dart View 1 chunk +1 line, -7 lines 0 comments Download
M pkg/compiler/lib/src/resolution/send_resolver.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolution/send_structure.dart View 6 chunks +51 lines, -45 lines 0 comments Download
M pkg/compiler/lib/src/warnings.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test.dart View 1 chunk +1 line, -3 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test_send_data.dart View 11 chunks +17 lines, -66 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
karlklose
5 years, 6 months ago (2015-06-12 12:03:14 UTC) #1
herhut
lgtm
5 years, 6 months ago (2015-06-12 12:03:52 UTC) #2
karlklose
Committed patchset #1 (id:1) manually as b01c4bd438357fc32cb00d69b4aa8a017f9dde1b (presubmit successful).
5 years, 6 months ago (2015-06-12 12:04:03 UTC) #3
Johnni Winther
5 years, 6 months ago (2015-06-12 12:15:00 UTC) #4
Message was sent while issue was closed.
LGTM, thanks.

Powered by Google App Engine
This is Rietveld 408576698