Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1185443002: Support for parsing HTML in the new task model (Closed)

Created:
5 years, 6 months ago by Brian Wilkerson
Modified:
5 years, 6 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, keertip
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+293 lines, -110 lines) Patch
M pkg/analyzer/lib/src/plugin/engine_plugin.dart View 2 chunks +2 lines, -0 lines 0 comments Download
A pkg/analyzer/lib/src/task/html.dart View 1 chunk +69 lines, -0 lines 0 comments Download
A pkg/analyzer/lib/task/html.dart View 1 chunk +21 lines, -0 lines 2 comments Download
M pkg/analyzer/pubspec.yaml View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/src/context/abstract_context.dart View 3 chunks +16 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 86 chunks +99 lines, -110 lines 0 comments Download
A pkg/analyzer/test/src/task/html_test.dart View 1 chunk +83 lines, -0 lines 2 comments Download
M pkg/analyzer/test/src/task/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Brian Wilkerson
5 years, 6 months ago (2015-06-11 20:04:41 UTC) #2
scheglov
LGTM https://codereview.chromium.org/1185443002/diff/1/pkg/analyzer/lib/task/html.dart File pkg/analyzer/lib/task/html.dart (right): https://codereview.chromium.org/1185443002/diff/1/pkg/analyzer/lib/task/html.dart#newcode20 pkg/analyzer/lib/task/html.dart:20: final ResultDescriptor<List<ParseError>> DOCUMENT_ERRORS = ListResultDescriptor? https://codereview.chromium.org/1185443002/diff/1/pkg/analyzer/test/src/task/html_test.dart File pkg/analyzer/test/src/task/html_test.dart ...
5 years, 6 months ago (2015-06-11 20:17:30 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/1185443002/diff/1/pkg/analyzer/lib/task/html.dart File pkg/analyzer/lib/task/html.dart (right): https://codereview.chromium.org/1185443002/diff/1/pkg/analyzer/lib/task/html.dart#newcode20 pkg/analyzer/lib/task/html.dart:20: final ResultDescriptor<List<ParseError>> DOCUMENT_ERRORS = Done https://codereview.chromium.org/1185443002/diff/1/pkg/analyzer/test/src/task/html_test.dart File pkg/analyzer/test/src/task/html_test.dart (right): ...
5 years, 6 months ago (2015-06-11 20:23:29 UTC) #4
Brian Wilkerson
5 years, 6 months ago (2015-06-11 20:24:25 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
980978c96748740dc7fea5244d38ac2643294983 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698