dart2js cps: Use JS semantics for logical operators in the tree IR.

dart2js cps: Use JS semantics for logical operators in the tree IR.

BUG=
R=kmillikin@google.com

Committed: https://github.com/dart-lang/sdk/commit/2bf1da7ac23bb4c16e33f5a13e853ee6dc629b0e

[asgerf, 2015-06-16 11:50:00]

asgerf@google.com changed reviewers:
+ kmillikin@google.com

[Kevin Millikin (Google), 2015-06-16 12:30:54]

LGTM.

https://codereview.chromium.org/1185333002/diff/1/pkg/compiler/lib/src/tree_i...
File pkg/compiler/lib/src/tree_ir/optimization/logical_rewriter.dart (right):

https://codereview.chromium.org/1185333002/diff/1/pkg/compiler/lib/src/tree_i...
pkg/compiler/lib/src/tree_ir/optimization/logical_rewriter.dart:142: bool
isOnlyFalsyValue(Expression condition, values.ConstantValue value) {
"is" is weird with the extra argument.  Maybe matchOnlyFalsyValue or the like is
a better clue that something more complicated is happening.

[asgerf, 2015-06-16 12:52:13]

https://codereview.chromium.org/1185333002/diff/1/pkg/compiler/lib/src/tree_i...
File pkg/compiler/lib/src/tree_ir/optimization/logical_rewriter.dart (right):

https://codereview.chromium.org/1185333002/diff/1/pkg/compiler/lib/src/tree_i...
pkg/compiler/lib/src/tree_ir/optimization/logical_rewriter.dart:142: bool
isOnlyFalsyValue(Expression condition, values.ConstantValue value) {
On 2015/06/16 12:30:54, Kevin Millikin (Google) wrote:
> "is" is weird with the extra argument.  Maybe matchOnlyFalsyValue or the like
is
> a better clue that something more complicated is happening.

"matchOnly" seems wrong, it could match other "patterns" too, so I settled for
"matchesFalsyValue".

[asgerf, 2015-06-16 13:21:35]

Committed patchset #2 (id:20001) manually as
2bf1da7ac23bb4c16e33f5a13e853ee6dc629b0e (presubmit successful).