Issue 11853011: Reapply "Add onClosed callbacks to HTTP output streams""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11853011: Reapply "Add onClosed callbacks to HTTP output streams"" (Closed)

Created:
7 years, 11 months ago by Søren Gjesse

Modified:
7 years, 11 months ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org, nweiz

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Reapply "Add onClosed callbacks to HTTP output streams"" The test have been rewritten to expect any order of the onClosed events. R=ager@google.com BUG=dart:7761 Committed: https://code.google.com/p/dart/source/detail?r=16969

Patch Set 1 #

Patch Set 2 : Updated test #

Patch Set 3 : Removed debug print #

Total comments: 2

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -5 lines)			Patch
	M	sdk/lib/io/http_impl.dart	View		7 chunks	+13 lines, -5 lines	0 comments	Download
	A	tests/standalone/io/http_stream_close_test.dart	View	1 2	1 chunk	+56 lines, -0 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

7 years, 11 months ago (2013-01-11 12:09:12 UTC) #2

LGTM

https://codereview.chromium.org/11853011/diff/4001/tests/standalone/io/http_s...
File tests/standalone/io/http_stream_close_test.dart (right):

https://codereview.chromium.org/11853011/diff/4001/tests/standalone/io/http_s...
tests/standalone/io/http_stream_close_test.dart:4: //
Remove this line?

https://codereview.chromium.org/11853011/diff/4001/tests/standalone/io/http_s...
tests/standalone/io/http_stream_close_test.dart:37: var connection =
client.postUrl(new Uri.fromString("http://127.0.0.1:${server.port}"));
Line line.

Expand Messages | Collapse Messages