Issue 1185013005: Assert helper threads do not (yet) attempt to access the "current zone".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1185013005: Assert helper threads do not (yet) attempt to access the "current zone". (Closed)

Created:
5 years, 6 months ago by koda

Modified:
5 years, 6 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Assert helper threads do not (yet) attempt to access the "current zone". This guards against a sweeper thread trying to directly allocate in the "current zone". This assertion will be removed when the "current zone" has completely migrated into Thread. BUG= R=iposva@google.com Committed: https://github.com/dart-lang/sdk/commit/c7e9dd2f99f95400664af723f18fb653031e1c2e

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -1 line)			Patch
	M	runtime/vm/base_isolate.h	View		1 chunk	+9 lines, -1 line	0 comments	Download
	M	runtime/vm/isolate.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

koda

5 years, 6 months ago (2015-06-17 15:25:32 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c7e9dd2f99f95400664af723f18fb653031e1c2e (presubmit successful).