Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 1184873002: Pass -EL for MIPS cross builds to allow for using a bi-endian toolchain... (Closed)

Created:
5 years, 6 months ago by rmacnak
Modified:
5 years, 6 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, ricow1
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Pass -EL for MIPS cross builds to allow for using a bi-endian toolchain and work around CXXFLAGS being passed to both host and target. R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/3d190ddd2d7d4bb4c9dcfaaf6bc5e58e7b54f671

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M tools/gyp/configurations_make.gypi View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
rmacnak
Makes the recommended toolchain for the CI20 happy. http://www.elinux.org/CI20_Dev_Zone#Toolchain Leaves bruno happy https://gfiber.googlesource.com/toolchains/bruno/
5 years, 6 months ago (2015-06-12 19:50:19 UTC) #2
zra
lgtm
5 years, 6 months ago (2015-06-12 19:58:23 UTC) #3
rmacnak
5 years, 6 months ago (2015-06-12 21:02:37 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3d190ddd2d7d4bb4c9dcfaaf6bc5e58e7b54f671 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698