Issue 1184853002: Cleanup TypedSelector.appliesUnnamed

Issue 1184853002: Cleanup TypedSelector.appliesUnnamed (Closed)

Created:
5 years, 6 months ago by Johnni Winther

Modified:
5 years, 6 months ago

Reviewers:
karlklose, herhut

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Cleanup TypedSelector.appliesUnnamed BUG= R=herhut@google.com, karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/ddcac2511720ffe1f551490cc02436f73e3c0017 Reverted: https://github.com/dart-lang/sdk/commit/fff0be1d6086c9aeb9dbcdcd13636a62518acdcc Committed: https://github.com/dart-lang/sdk/commit/ae507cfc6de11541943dc8ea95339f15387bb466

Patch Set 2 : Update comment. #

Total comments: 1

Patch Set 4 : Emit top level and static getters/setters for mirrors. #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -22 lines)			Patch
M	pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart	View	1 2 3	1 chunk	+13 lines, -9 lines	0 comments	Download
M	pkg/compiler/lib/src/types/type_mask.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/universe/universe.dart	View		1 chunk	+0 lines, -12 lines	0 comments	Download

Messages

Total messages: 10 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

karlklose

https://codereview.chromium.org/1184853002/diff/20001/pkg/compiler/lib/src/types/type_mask.dart File pkg/compiler/lib/src/types/type_mask.dart (right): https://codereview.chromium.org/1184853002/diff/20001/pkg/compiler/lib/src/types/type_mask.dart#newcode26 pkg/compiler/lib/src/types/type_mask.dart:26: "uninstantiated class $base")); Thank you!

5 years, 6 months ago (2015-06-17 11:39:30 UTC) #5

Johnni Winther

Committed patchset #2 (id:20001) manually as ddcac2511720ffe1f551490cc02436f73e3c0017 (presubmit successful).

5 years, 6 months ago (2015-06-17 12:40:40 UTC) #6

Johnni Winther

5 years, 6 months ago (2015-06-18 08:33:22 UTC) #10

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as
ae507cfc6de11541943dc8ea95339f15387bb466 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages