Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1184183010: Revise static typecheck rules for for-in. (Closed)

Created:
5 years, 6 months ago by gbracha
Modified:
5 years, 6 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : correction #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M docs/language/dartLangSpec.tex View 1 1 chunk +1 line, -11 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
gbracha
5 years, 6 months ago (2015-06-15 23:18:08 UTC) #2
Paul Berry
lgtm assuming the fix below is applied. https://codereview.chromium.org/1184183010/diff/1/docs/language/dartLangSpec.tex File docs/language/dartLangSpec.tex (right): https://codereview.chromium.org/1184183010/diff/1/docs/language/dartLangSpec.tex#newcode5686 docs/language/dartLangSpec.tex:5686: where \code{n0} ...
5 years, 6 months ago (2015-06-16 00:13:30 UTC) #3
gbracha
PTAL
5 years, 6 months ago (2015-06-16 00:48:43 UTC) #4
gbracha
5 years, 6 months ago (2015-06-16 00:50:42 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f71b48a0413b43465e6e169a55012f08fd09cee3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698