Issue 1184183006: Better errors for pkg/fixnum

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1184183006: Better errors for pkg/fixnum (Closed)

Created:
5 years, 6 months ago by sra1

Modified:
5 years, 6 months ago

Reviewers:
Chris Bracken, Lasse Reichstein Nielsen

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Better errors for pkg/fixnum Replace `new ArgumentError(x)` with `new ArgumentError.value(x)`. Throw RangeError for bad radix arguments. R=cbracken@google.com Committed: https://github.com/dart-lang/sdk/commit/7926e2630f548b91d4ca29d38c8670dd8bc03211

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -44 lines)			Patch
M	pkg/fixnum/lib/src/int32.dart	View		2 chunks	+8 lines, -5 lines	0 comments	Download
M	pkg/fixnum/lib/src/int64.dart	View		8 chunks	+15 lines, -21 lines	0 comments	Download
M	pkg/fixnum/pubspec.yaml	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/fixnum/test/int_32_test.dart	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	pkg/fixnum/test/int_64_test.dart	View		18 chunks	+32 lines, -13 lines	0 comments	Download

Total messages: 7 (2 generated)

sra1

5 years, 6 months ago (2015-06-19 19:35:20 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
7926e2630f548b91d4ca29d38c8670dd8bc03211 (presubmit successful).