Issue 1183533002: Compute RESOLVED_UNIT for all units in all of the libraries of the closure before verifying.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1183533002: Compute RESOLVED_UNIT for all units in all of the libraries of the closure before verifying. (Closed)

Created:
5 years, 6 months ago by scheglov

Modified:
5 years, 6 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Compute RESOLVED_UNIT for all units in all of the libraries of the closure before verifying. This fixes many co19 tests, so I guess it might solve the problems with constants you mentioned. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/b8067b5fb9621c4f133e304a85e7ccd27de27028

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -5 lines)			Patch
	M	pkg/analysis_server/test/analysis_server_test.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	pkg/analyzer/lib/src/task/dart.dart	View		2 chunks	+5 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

Brian Wilkerson

LGTM I'll re-run the tests after this is committed.

5 years, 6 months ago (2015-06-11 17:34:30 UTC) #2

scheglov

5 years, 6 months ago (2015-06-11 17:47:31 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b8067b5fb9621c4f133e304a85e7ccd27de27028 (presubmit successful).