Regression test for issue http://code.google.com/p/dart/issues/detail?id=7448.

Regression test for issue http://code.google.com/p/dart/issues/detail?id=7448.
Committed: https://code.google.com/p/dart/source/detail?r=17453

[ahe, 2013-01-18 12:13:27]

LGTM!

https://codereview.chromium.org/11833037/diff/2001/tests/isolate/isolate.status
File tests/isolate/isolate.status (right):

https://codereview.chromium.org/11833037/diff/2001/tests/isolate/isolate.stat...
tests/isolate/isolate.status:11: ports_compilation_browser_test: Skip # browser
specific test
I think it should just be marked fail, I suggest you check with Ivan.

[ngeoffray, 2013-01-18 12:19:26]

Thanks Peter.

https://codereview.chromium.org/11833037/diff/2001/tests/isolate/isolate.status
File tests/isolate/isolate.status (right):

https://codereview.chromium.org/11833037/diff/2001/tests/isolate/isolate.stat...
tests/isolate/isolate.status:11: ports_compilation_browser_test: Skip # browser
specific test
On 2013/01/18 12:13:27, ahe wrote:
> I think it should just be marked fail, I suggest you check with Ivan.

@Ivan what do you prefer for browser-only tests: do you want them marked as fail
for the VM or skip them?

They will always fail because of:
$ ./out/ReleaseIA32/dart tests/isolate/compute_this_script_browser_test.dart 
Do not know how to load
'dart:html''file:///usr/local/google/home/ngeoffray/projects/dart2/dart/tests/isolate/compute_this_script_browser_test.dart':
Error: line 10 pos 1: library handler failed
import 'dart:html';
^

[Ivan Posva, 2013-01-23 04:00:52]

https://codereview.chromium.org/11833037/diff/2001/tests/isolate/isolate.status
File tests/isolate/isolate.status (right):

https://codereview.chromium.org/11833037/diff/2001/tests/isolate/isolate.stat...
tests/isolate/isolate.status:11: ports_compilation_browser_test: Skip # browser
specific test
On 2013/01/18 12:19:26, ngeoffray wrote:
> On 2013/01/18 12:13:27, ahe wrote:
> > I think it should just be marked fail, I suggest you check with Ivan.
> 
> @Ivan what do you prefer for browser-only tests: do you want them marked as
fail
> for the VM or skip them?
> 
> They will always fail because of:
> $ ./out/ReleaseIA32/dart tests/isolate/compute_this_script_browser_test.dart 
> Do not know how to load
>
'dart:html''file:///usr/local/google/home/ngeoffray/projects/dart2/dart/tests/isolate/compute_this_script_browser_test.dart':
> Error: line 10 pos 1: library handler failed
> import 'dart:html';
> ^

Skip is the correct thing here as the test is not applicable to $runtime==vm.

[ngeoffray, 2013-01-23 12:59:51]

https://codereview.chromium.org/11833037/diff/2001/tests/isolate/isolate.status
File tests/isolate/isolate.status (right):

https://codereview.chromium.org/11833037/diff/2001/tests/isolate/isolate.stat...
tests/isolate/isolate.status:11: ports_compilation_browser_test: Skip # browser
specific test
On 2013/01/23 04:00:52, Ivan Posva wrote:
> On 2013/01/18 12:19:26, ngeoffray wrote:
> > On 2013/01/18 12:13:27, ahe wrote:
> > > I think it should just be marked fail, I suggest you check with Ivan.
> > 
> > @Ivan what do you prefer for browser-only tests: do you want them marked as
> fail
> > for the VM or skip them?
> > 
> > They will always fail because of:
> > $ ./out/ReleaseIA32/dart tests/isolate/compute_this_script_browser_test.dart

> > Do not know how to load
> >
>
'dart:html''file:///usr/local/google/home/ngeoffray/projects/dart2/dart/tests/isolate/compute_this_script_browser_test.dart':
> > Error: line 10 pos 1: library handler failed
> > import 'dart:html';
> > ^
> 
> Skip is the correct thing here as the test is not applicable to $runtime==vm.

OK, thanks Ivan.