Issue 11833035: Status file updates for jsshell

Issue 11833035: Status file updates for jsshell (Closed)

Created:
7 years, 11 months ago by kustermann

Modified:
7 years, 11 months ago

Reviewers:
ricow1, ahe, ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Status file updates for jsshell Committed: https://code.google.com/p/dart/source/detail?r=16920

Patch Set 1 #

Total comments: 6

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+69 lines, -9 lines)			Patch
M	pkg/pkg.status	View	2 chunks	+19 lines, -1 line	1 comment	Download
M	tests/co19/co19-dart2js.status	View	1 chunk	+13 lines, -7 lines	1 comment	Download
M	tests/isolate/isolate.status	View	1 chunk	+17 lines, -0 lines	1 comment	Download
M	tests/language/language.status	View	1 chunk	+5 lines, -0 lines	1 comment	Download
M	tests/lib/lib.status	View	1 chunk	+14 lines, -0 lines	1 comment	Download
M	tools/bots/pub.py	View	1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM, but sooooooooooooooo many typos :-) https://codereview.chromium.org/11833035/diff/1/pkg/pkg.status File pkg/pkg.status (right): https://codereview.chromium.org/11833035/diff/1/pkg/pkg.status#newcode88 pkg/pkg.status:88: args/test/args_test: Fail # ...

7 years, 11 months ago (2013-01-10 14:19:34 UTC) #4

kustermann

7 years, 11 months ago (2013-01-10 16:32:15 UTC) #5

Message was sent while issue was closed.

On 2013/01/10 14:19:34, ngeoffray wrote:
> LGTM, but sooooooooooooooo many typos :-)

Sorry for that. (I typed it only once, and used a VIM macro for the other
places).

> PUB_BUILDER = r'pub-(linux|mac|win)(-russian)?'
> Is that related?

It's not related (I could've made another CL for it). It's necessary for moving
the russian pub bot to the main waterfall (along with the jsshell builders).

Expand Messages | Collapse Messages