Issue 11833031: Status update: io/test_runner_test is passing + small fix in test_runner_test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11833031: Status update: io/test_runner_test is passing + small fix in test_runner_test (Closed)

Created:
7 years, 11 months ago by kustermann

Modified:
7 years, 11 months ago

Reviewers:
ricow1, Bill Hesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Status update: io/test_runner_test is passing + small fix in test_runner_test Committed: https://code.google.com/p/dart/source/detail?r=16905

Patch Set 3 : #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -5 lines)			Patch
	M	tests/standalone/io/test_runner_test.dart	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
	M	tests/standalone/standalone.status	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ricow1

LGTM https://codereview.chromium.org/11833031/diff/3001/tests/standalone/io/test_runner_test.dart File tests/standalone/io/test_runner_test.dart (right): https://codereview.chromium.org/11833031/diff/3001/tests/standalone/io/test_runner_test.dart#newcode26 tests/standalone/io/test_runner_test.dart:26: print("\n"); remove this extra line https://codereview.chromium.org/11833031/diff/3001/tests/standalone/io/test_runner_test.dart#newcode29 tests/standalone/io/test_runner_test.dart:29: print("\n"); ...

7 years, 11 months ago (2013-01-10 09:29:43 UTC) #2

kustermann

7 years, 11 months ago (2013-01-10 09:30:45 UTC) #3

https://codereview.chromium.org/11833031/diff/3001/tests/standalone/io/test_r...
File tests/standalone/io/test_runner_test.dart (right):

https://codereview.chromium.org/11833031/diff/3001/tests/standalone/io/test_r...
tests/standalone/io/test_runner_test.dart:26: print("\n");
On 2013/01/10 09:29:43, ricow1 wrote:
> remove this extra line

Done.

https://codereview.chromium.org/11833031/diff/3001/tests/standalone/io/test_r...
tests/standalone/io/test_runner_test.dart:29: print("\n");
On 2013/01/10 09:29:43, ricow1 wrote:
> remove this extra line

Done.

Expand Messages | Collapse Messages

Issue 11833031: Status update: io/test_runner_test is passing + small fix in test_runner_test (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages