Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1182983003: Update dartium deps to include html (Closed)

Created:
5 years, 6 months ago by Brian Wilkerson
Modified:
5 years, 6 months ago
Reviewers:
vsm, siva
CC:
reviews_dartlang.org, ricow1
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Remove unwanted change #

Total comments: 2

Patch Set 3 : Inline undefined variables #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tools/deps/dartium.deps/DEPS View 1 2 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Brian Wilkerson
I would love to get directions on how to test this before committing it.
5 years, 6 months ago (2015-06-13 14:35:49 UTC) #2
vsm
You can test by following the build instructions here: https://github.com/dart-lang/sdk/wiki/Building-Dartium You probably only need to ...
5 years, 6 months ago (2015-06-13 17:20:27 UTC) #3
Brian Wilkerson
PTAL. I ran "gclient runhooks" and didn't get any errors. https://codereview.chromium.org/1182983003/diff/20001/tools/deps/dartium.deps/DEPS File tools/deps/dartium.deps/DEPS (right): https://codereview.chromium.org/1182983003/diff/20001/tools/deps/dartium.deps/DEPS#newcode97 ...
5 years, 6 months ago (2015-06-15 15:01:58 UTC) #4
vsm
lgtm
5 years, 6 months ago (2015-06-15 15:13:05 UTC) #5
Brian Wilkerson
5 years, 6 months ago (2015-06-15 15:45:16 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
1ac16bd2d45f9d4f00afca1c72d9b955414d7f4f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698