Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1182913003: Split TypedSelector into Selector and TypeMask. (Closed)

Created:
5 years, 6 months ago by Johnni Winther
Modified:
5 years, 6 months ago
Reviewers:
karlklose, herhut
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : Updated cf. comments #

Patch Set 4 : Rebased #

Patch Set 5 : Bug fix and status update #

Patch Set 6 : Cache FlatTypeMask in World #

Patch Set 7 : Add SelectorMask for FunctionSetNode.cache #

Total comments: 4

Patch Set 8 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1237 lines, -742 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 1 2 3 4 5 4 chunks +7 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 1 2 3 4 5 10 chunks +30 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 1 2 3 4 5 34 chunks +88 lines, -67 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart View 1 2 3 4 5 3 chunks +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 1 2 3 4 5 4 chunks +6 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend.dart View 2 chunks +14 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/dart_backend.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/dump_info.dart View 6 chunks +12 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 1 9 chunks +37 lines, -39 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/closure_tracer.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/concrete_types_inferrer.dart View 1 9 chunks +22 lines, -16 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/inferrer_visitor.dart View 3 chunks +6 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart View 1 43 chunks +162 lines, -87 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart View 1 12 chunks +39 lines, -32 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_nodes.dart View 1 14 chunks +47 lines, -39 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 2 3 4 5 3 chunks +7 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/codegen.dart View 1 2 3 4 5 3 chunks +7 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/class_stub_generator.dart View 1 3 chunks +24 lines, -16 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/js_emitter.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/parameter_stub_generator.dart View 1 4 chunks +13 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 19 chunks +49 lines, -27 lines 0 comments Download
M pkg/compiler/lib/src/resolution/registry.dart View 5 chunks +23 lines, -21 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 1 chunk +5 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/tree_elements.dart View 1 3 chunks +75 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 2 3 4 5 37 chunks +104 lines, -54 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 5 chunks +25 lines, -15 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen_helpers.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/interceptor_simplifier.dart View 3 chunks +6 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/invoke_dynamic_specializers.dart View 4 chunks +7 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/ssa/nodes.dart View 19 chunks +69 lines, -33 lines 0 comments Download
M pkg/compiler/lib/src/ssa/optimize.dart View 9 chunks +25 lines, -17 lines 0 comments Download
M pkg/compiler/lib/src/ssa/ssa_tracer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/types.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/types_propagation.dart View 3 chunks +8 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart View 1 2 3 3 chunks +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/types/flat_type_mask.dart View 1 2 3 4 5 3 chunks +14 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/types/forwarding_type_mask.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/types/type_mask.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/types/types.dart View 2 chunks +7 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/types/union_type_mask.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/universe/function_set.dart View 1 2 3 4 5 6 7 5 chunks +53 lines, -25 lines 0 comments Download
M pkg/compiler/lib/src/universe/universe.dart View 1 2 3 4 6 chunks +130 lines, -96 lines 0 comments Download
M pkg/compiler/lib/src/use_unused_api.dart View 1 3 chunks +2 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/world.dart View 1 2 3 4 5 6 7 4 chunks +24 lines, -12 lines 0 comments Download
M tests/compiler/dart2js/compiler_helper.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M tests/compiler/dart2js/cpa_inference_test.dart View 1 3 chunks +15 lines, -7 lines 0 comments Download
M tests/compiler/dart2js/gvn_dynamic_field_get_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/patch_test.dart View 1 3 chunks +11 lines, -14 lines 0 comments Download
M tests/language/language_dart2js.status View 1 2 3 4 5 2 chunks +24 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
Johnni Winther
5 years, 6 months ago (2015-06-17 12:15:11 UTC) #2
karlklose
LGTM! https://codereview.chromium.org/1182913003/diff/20001/pkg/compiler/lib/src/ssa/builder.dart File pkg/compiler/lib/src/ssa/builder.dart (right): https://codereview.chromium.org/1182913003/diff/20001/pkg/compiler/lib/src/ssa/builder.dart#newcode5553 pkg/compiler/lib/src/ssa/builder.dart:5553: if (selector.name == 'double') { Remove debug code. ...
5 years, 6 months ago (2015-06-17 12:43:12 UTC) #3
Johnni Winther
https://codereview.chromium.org/1182913003/diff/20001/pkg/compiler/lib/src/ssa/builder.dart File pkg/compiler/lib/src/ssa/builder.dart (right): https://codereview.chromium.org/1182913003/diff/20001/pkg/compiler/lib/src/ssa/builder.dart#newcode5553 pkg/compiler/lib/src/ssa/builder.dart:5553: if (selector.name == 'double') { On 2015/06/17 12:43:11, karlklose ...
5 years, 6 months ago (2015-06-17 13:03:53 UTC) #4
Johnni Winther
PTAL @ the last patch
5 years, 6 months ago (2015-06-18 09:30:05 UTC) #5
karlklose
Still LGTM.
5 years, 6 months ago (2015-06-18 09:39:50 UTC) #6
Johnni Winther
Committed patchset #5 (id:70001) manually as fc42c0e3bd30b3249f930d521a42af53366abcfd (presubmit successful).
5 years, 6 months ago (2015-06-18 09:47:46 UTC) #7
Johnni Winther
PTAL @ the last patch (world.dart and flat_type_mask.dart)
5 years, 6 months ago (2015-06-23 09:53:53 UTC) #9
herhut
lgtm https://codereview.chromium.org/1182913003/diff/110001/pkg/compiler/lib/src/universe/function_set.dart File pkg/compiler/lib/src/universe/function_set.dart (right): https://codereview.chromium.org/1182913003/diff/110001/pkg/compiler/lib/src/universe/function_set.dart#newcode175 pkg/compiler/lib/src/universe/function_set.dart:175: FunctionSetQuery query(Selector selector, As discussed, it would be ...
5 years, 6 months ago (2015-06-24 15:19:29 UTC) #10
Johnni Winther
https://codereview.chromium.org/1182913003/diff/110001/pkg/compiler/lib/src/universe/function_set.dart File pkg/compiler/lib/src/universe/function_set.dart (right): https://codereview.chromium.org/1182913003/diff/110001/pkg/compiler/lib/src/universe/function_set.dart#newcode175 pkg/compiler/lib/src/universe/function_set.dart:175: FunctionSetQuery query(Selector selector, On 2015/06/24 15:19:29, herhut wrote: > ...
5 years, 6 months ago (2015-06-25 07:25:28 UTC) #11
Johnni Winther
5 years, 6 months ago (2015-06-25 08:13:20 UTC) #12
Message was sent while issue was closed. 
Committed patchset #8 (id:130001) manually as
507bc962d7b4d7cf9d06b21857d60e2c3094ffb2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698