Issue 11829020: Report errors on repeated interfaces.

Issue 11829020: Report errors on repeated interfaces. (Closed)

Created:
7 years, 11 months ago by Johnni Winther

Modified:
7 years, 11 months ago

Reviewers:
ahe, karlklose

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Report errors on repeated interfaces. BUG=http://dartbug.com/7468 Committed: https://code.google.com/p/dart/source/detail?r=16900

Patch Set 3 : Updated cf. comment + class_cyclic_test updated #

Patch Set 4 : Rebased #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -8 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/resolution/members.dart	View	1 2	1 chunk	+16 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/warnings.dart	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download
M	tests/co19/co19-dart2dart.status	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/co19/co19-dart2js.status	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/language/class_cycle_test.dart	View	1 2	1 chunk	+10 lines, -2 lines	0 comments	Download
M	tests/language/language.status	View	1 2 3	1 chunk	+0 lines, -2 lines	0 comments	Download
M	tests/language/language_dart2js.status	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM https://codereview.chromium.org/11829020/diff/1/sdk/lib/_internal/compiler/implementation/resolution/members.dart File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right): https://codereview.chromium.org/11829020/diff/1/sdk/lib/_internal/compiler/implementation/resolution/members.dart#newcode2713 sdk/lib/_internal/compiler/implementation/resolution/members.dart:2713: error(link.head, As these errors are recoverable, it would ...

7 years, 11 months ago (2013-01-09 13:15:31 UTC) #2

Johnni Winther

7 years, 11 months ago (2013-01-10 06:55:13 UTC) #3

https://codereview.chromium.org/11829020/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right):

https://codereview.chromium.org/11829020/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:2713:
error(link.head,
On 2013/01/09 13:15:31, ahe wrote:
> As these errors are recoverable, it would be nice to use reportMessage
instead.

Done.

https://codereview.chromium.org/11829020/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/warnings.dart (right):

https://codereview.chromium.org/11829020/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/warnings.dart:203: static const
DUPLICATE_EXTENDS_IMPLEMENTS = const MessageKind(
On 2013/01/09 13:15:31, ahe wrote:
> Would these errors be easier to understand if we reported both locations?

Done.

https://codereview.chromium.org/11829020/diff/1/tests/language/language.status
File tests/language/language.status (right):

https://codereview.chromium.org/11829020/diff/1/tests/language/language.statu...
tests/language/language.status:1: 
On 2013/01/09 13:15:31, ahe wrote:
> Remove extra line.

Done.

Expand Messages | Collapse Messages