Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 118273004: Handle typedefs in registerRequiredType. (Closed)

Created:
7 years ago by Johnni Winther
Modified:
7 years ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Handle typedefs in registerRequiredType. BUG= R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=31327

Patch Set 1 #

Total comments: 2

Patch Set 2 : */ #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -31 lines) Patch
M sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart View 1 1 chunk +3 lines, -4 lines 2 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/backend.dart View 1 1 chunk +9 lines, -27 lines 0 comments Download
A tests/language/type_variable_typedef_test.dart View 1 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Johnni Winther
7 years ago (2013-12-19 12:24:51 UTC) #1
karlklose
On 2013/12/19 12:24:51, Johnni Winther wrote: Can you add a test?
7 years ago (2013-12-19 12:29:38 UTC) #2
karlklose
https://codereview.chromium.org/118273004/diff/1/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart File sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (right): https://codereview.chromium.org/118273004/diff/1/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart#newcode1009 sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:1009: /** Change to '//' comment style, this is not ...
7 years ago (2013-12-19 12:29:48 UTC) #3
ahe
DBC: Can you test this?
7 years ago (2013-12-19 14:44:41 UTC) #4
Johnni Winther
PTAL https://codereview.chromium.org/118273004/diff/1/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart File sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (right): https://codereview.chromium.org/118273004/diff/1/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart#newcode1009 sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:1009: /** On 2013/12/19 12:29:48, karlklose wrote: > Change ...
7 years ago (2013-12-19 15:27:56 UTC) #5
karlklose
LGTM. https://codereview.chromium.org/118273004/diff/40001/sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart File sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart (right): https://codereview.chromium.org/118273004/diff/40001/sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart#newcode91 sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart:91: if (type is GenericType) { Merge the two ...
7 years ago (2013-12-20 07:43:20 UTC) #6
Johnni Winther
https://codereview.chromium.org/118273004/diff/40001/sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart File sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart (right): https://codereview.chromium.org/118273004/diff/40001/sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart#newcode91 sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart:91: if (type is GenericType) { On 2013/12/20 07:43:20, karlklose ...
7 years ago (2013-12-20 10:14:37 UTC) #7
Johnni Winther
7 years ago (2013-12-20 10:15:54 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 manually as r31327 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698