Consider a thrown AsyncError from a future/stream handler a rethrow.

Consider a thrown AsyncError from a future/stream handler a rethrow.

The AsyncError is not wrapped, but is used directly as the async error.

BUG=dartbug.com/7781

Committed: https://code.google.com/p/dart/source/detail?r=16950

[floitsch, 2013-01-10 16:38:10]

LGTM.

https://codereview.chromium.org/11826050/diff/1/sdk/lib/async/future.dart
File sdk/lib/async/future.dart (right):

https://codereview.chromium.org/11826050/diff/1/sdk/lib/async/future.dart#new...
sdk/lib/async/future.dart:69: * as the error result, otherwise it's wrapped in
an [AsyncError] first.
it is

https://codereview.chromium.org/11826050/diff/1/sdk/lib/async/future.dart#new...
sdk/lib/async/future.dart:92: * emitted by the returned Future unmodified.
In theory it is, as if the handler was a 'then'-handler. But I'm not sure if
that simplifies the description.

https://codereview.chromium.org/11826050/diff/1/sdk/lib/async/future.dart#new...
sdk/lib/async/future.dart:179: * Otherwise the [exception] and an optional
[stackTrace] is combined and sent
.. is combined into an [AsyncError] and ...

https://codereview.chromium.org/11826050/diff/1/sdk/lib/async/stream_controll...
File sdk/lib/async/stream_controller.dart (right):

https://codereview.chromium.org/11826050/diff/1/sdk/lib/async/stream_controll...
sdk/lib/async/stream_controller.dart:89: * error object reported to listeners,
and the [stackTrace] is ignored.
I would mention the special case after the normal case.
Maybe:

If the [exception] is not an [AsyncError], combines the [exception] and the
optional [stackTrace] into an [AsyncError] and sends the result to [this]
stream's listeners.

If the [exception] is already an [AsyncError], then the [stackTrace] is ignored
and the [exception] is sent directly to the listeners.

[Bob Nystrom, 2013-01-10 18:30:15]

On 2013/01/10 16:38:10, floitsch wrote:
> LGTM.
> 
> https://codereview.chromium.org/11826050/diff/1/sdk/lib/async/future.dart
> File sdk/lib/async/future.dart (right):
> 
>
https://codereview.chromium.org/11826050/diff/1/sdk/lib/async/future.dart#new...
> sdk/lib/async/future.dart:69: * as the error result, otherwise it's wrapped in
> an [AsyncError] first.
> it is
> 
>
https://codereview.chromium.org/11826050/diff/1/sdk/lib/async/future.dart#new...
> sdk/lib/async/future.dart:92: * emitted by the returned Future unmodified.
> In theory it is, as if the handler was a 'then'-handler. But I'm not sure if
> that simplifies the description.
> 
>
https://codereview.chromium.org/11826050/diff/1/sdk/lib/async/future.dart#new...
> sdk/lib/async/future.dart:179: * Otherwise the [exception] and an optional
> [stackTrace] is combined and sent
> .. is combined into an [AsyncError] and ...
> 
>
https://codereview.chromium.org/11826050/diff/1/sdk/lib/async/stream_controll...
> File sdk/lib/async/stream_controller.dart (right):
> 
>
https://codereview.chromium.org/11826050/diff/1/sdk/lib/async/stream_controll...
> sdk/lib/async/stream_controller.dart:89: * error object reported to listeners,
> and the [stackTrace] is ignored.
> I would mention the special case after the normal case.
> Maybe:
> 
> If the [exception] is not an [AsyncError], combines the [exception] and the
> optional [stackTrace] into an [AsyncError] and sends the result to [this]
> stream's listeners.
> 
> If the [exception] is already an [AsyncError], then the [stackTrace] is
ignored
> and the [exception] is sent directly to the listeners.

I hate to be that guy, but are there tests that go with this change?

[Lasse Reichstein Nielsen, 2013-01-11 07:02:05]

Aww, Bob! :)
Tests added for future. 

Stream isn't actually changed, and I'm no longer convinced that it doesn't need
it.

https://codereview.chromium.org/11826050/diff/1/sdk/lib/async/future.dart
File sdk/lib/async/future.dart (right):

https://codereview.chromium.org/11826050/diff/1/sdk/lib/async/future.dart#new...
sdk/lib/async/future.dart:69: * as the error result, otherwise it's wrapped in
an [AsyncError] first.
On 2013/01/10 16:38:10, floitsch wrote:
> it is

Done.

https://codereview.chromium.org/11826050/diff/1/sdk/lib/async/future.dart#new...
sdk/lib/async/future.dart:92: * emitted by the returned Future unmodified.
Not really, no.

https://codereview.chromium.org/11826050/diff/1/sdk/lib/async/future.dart#new...
sdk/lib/async/future.dart:179: * Otherwise the [exception] and an optional
[stackTrace] is combined and sent
On 2013/01/10 16:38:10, floitsch wrote:
> .. is combined into an [AsyncError] and ...

Done.

https://codereview.chromium.org/11826050/diff/1/sdk/lib/async/stream_controll...
File sdk/lib/async/stream_controller.dart (right):

https://codereview.chromium.org/11826050/diff/1/sdk/lib/async/stream_controll...
sdk/lib/async/stream_controller.dart:89: * error object reported to listeners,
and the [stackTrace] is ignored.
On 2013/01/10 16:38:10, floitsch wrote:
> I would mention the special case after the normal case.
> Maybe:
> 
> If the [exception] is not an [AsyncError], combines the [exception] and the
> optional [stackTrace] into an [AsyncError] and sends the result to [this]
> stream's listeners.
> 
> If the [exception] is already an [AsyncError], then the [stackTrace] is
ignored
> and the [exception] is sent directly to the listeners.

Done.