Handle most qualified sends.

Handle most qualified sends.

BUG=
R=herhut@google.com, karlklose@google.com

Committed: https://github.com/dart-lang/sdk/commit/ec40a1401993d97a01a7fa3001035b7206986796

Reverted: https://github.com/dart-lang/sdk/commit/b01c4bd438357fc32cb00d69b4aa8a017f9dde1b

Committed: https://github.com/dart-lang/sdk/commit/6c8b4bb7af9cd8f9dde68ddaf6c9b6b233b20286

[Johnni Winther, 2015-06-11 19:34:54]

johnniwinther@google.com changed reviewers:
+ karlklose@google.com

[karlklose, 2015-06-12 07:01:03]

LGTM.

https://codereview.chromium.org/1182563003/diff/20001/pkg/compiler/lib/src/re...
File pkg/compiler/lib/src/resolution/access_semantics.dart (right):

https://codereview.chromium.org/1182563003/diff/20001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/access_semantics.dart:22: IF_NOT_NULL_PROPERTY,
Shoudn't this be IF_DYNAMIC_PROPERTY or CONDITIONAL_DYNAMIC_PROPERTY, similar to
the case below?

https://codereview.chromium.org/1182563003/diff/20001/pkg/compiler/lib/src/re...
File pkg/compiler/lib/src/resolution/members.dart (right):

https://codereview.chromium.org/1182563003/diff/20001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/members.dart:1595:
registry.registerThrowNoSuchMethod();
Share code with l. 1599-1630, making the message kind a parameter?

https://codereview.chromium.org/1182563003/diff/20001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/members.dart:1655: /// `a` is class and `b` is a
static member of `a`.
"`a` is *a* class"

https://codereview.chromium.org/1182563003/diff/20001/pkg/compiler/lib/src/re...
File pkg/compiler/lib/src/resolution/resolution_common.dart (right):

https://codereview.chromium.org/1182563003/diff/20001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/resolution_common.dart:17:
assert(invariant(element, element is! ErroneousElement,
Do we have a predicate to test that instead of an is check? If not, maybe add a
TODO to add one.

[Johnni Winther, 2015-06-12 07:50:30]

https://codereview.chromium.org/1182563003/diff/20001/pkg/compiler/lib/src/re...
File pkg/compiler/lib/src/resolution/access_semantics.dart (right):

https://codereview.chromium.org/1182563003/diff/20001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/access_semantics.dart:22: IF_NOT_NULL_PROPERTY,
On 2015/06/12 07:01:02, karlklose wrote:
> Shoudn't this be IF_DYNAMIC_PROPERTY or CONDITIONAL_DYNAMIC_PROPERTY, similar
to
> the case below?

Done.

https://codereview.chromium.org/1182563003/diff/20001/pkg/compiler/lib/src/re...
File pkg/compiler/lib/src/resolution/members.dart (right):

https://codereview.chromium.org/1182563003/diff/20001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/members.dart:1595:
registry.registerThrowNoSuchMethod();
On 2015/06/12 07:01:03, karlklose wrote:
> Share code with l. 1599-1630, making the message kind a parameter?

Added a TODO. I wan't to specialize the semantics and use the element if
present.

https://codereview.chromium.org/1182563003/diff/20001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/members.dart:1655: /// `a` is class and `b` is a
static member of `a`.
On 2015/06/12 07:01:03, karlklose wrote:
> "`a` is *a* class"

Done.

https://codereview.chromium.org/1182563003/diff/20001/pkg/compiler/lib/src/re...
File pkg/compiler/lib/src/resolution/resolution_common.dart (right):

https://codereview.chromium.org/1182563003/diff/20001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/resolution_common.dart:17:
assert(invariant(element, element is! ErroneousElement,
On 2015/06/12 07:01:03, karlklose wrote:
> Do we have a predicate to test that instead of an is check? If not, maybe add
a
> TODO to add one.

Done.

[Johnni Winther, 2015-06-12 07:51:38]

Committed patchset #4 (id:60001) manually as
ec40a1401993d97a01a7fa3001035b7206986796 (presubmit successful).

[Johnni Winther, 2015-06-12 13:00:06]

johnniwinther@google.com changed reviewers:
+ herhut@google.com

[Johnni Winther, 2015-06-12 13:00:06]

johnniwinther@google.com changed reviewers:
+ herhut@google.com

[Johnni Winther, 2015-06-12 13:00:06]

herhet@: PTAL @ the last patch

[Johnni Winther, 2015-06-12 13:00:06]

herhet@: PTAL @ the last patch

[Johnni Winther, 2015-06-12 13:00:22]

herhet -> herhut!

[herhut, 2015-06-12 13:10:00]

lgtm

[Johnni Winther, 2015-06-12 13:26:19]

Committed patchset #5 (id:80001) manually as
6c8b4bb7af9cd8f9dde68ddaf6c9b6b233b20286 (presubmit successful).