Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 118253004: Remove tracking of factories with type arguments. (Closed)

Created:
7 years ago by karlklose
Modified:
7 years ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove tracking of factories with type arguments. Instead, calculate the necessary checks from rti-dependencies and classes that use their type variables in checks. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=31320

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -54 lines) Patch
M sdk/lib/_internal/compiler/implementation/dart_types.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/enqueue.dart View 1 chunk +0 lines, -9 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart View 2 chunks +36 lines, -34 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 1 chunk +1 line, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/builder.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/universe/universe.dart View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
karlklose
7 years ago (2013-12-19 13:47:47 UTC) #1
Johnni Winther
lgtm
7 years ago (2013-12-19 14:13:12 UTC) #2
karlklose
7 years ago (2013-12-20 07:38:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r31320 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698