Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 11825012: Fix for go.sh breaking because the dart binary in /testing hasn't been updated. (Closed)

Created:
7 years, 11 months ago by Andrei Mouravski
Modified:
7 years, 11 months ago
Reviewers:
blois
CC:
reviews_dartlang.org, Emily Fortuna
Visibility:
Public.

Description

Fix for go.sh breaking because the dart binary in /testing hasn't been updated. Committed: https://code.google.com/p/dart/source/detail?r=16937

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M tools/dom/scripts/dartdomgenerator.py View 1 chunk +1 line, -1 line 2 comments Download
M tools/utils.py View 1 chunk +6 lines, -0 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
Andrei Mouravski
That'll do it... I hope.
7 years, 11 months ago (2013-01-08 23:24:55 UTC) #1
blois
On 2013/01/08 23:24:55, Andrei Mouravski wrote: > That'll do it... I hope. This points to ...
7 years, 11 months ago (2013-01-09 00:22:36 UTC) #2
blois
https://codereview.chromium.org/11825012/diff/1/tools/dom/scripts/dartdomgenerator.py File tools/dom/scripts/dartdomgenerator.py (right): https://codereview.chromium.org/11825012/diff/1/tools/dom/scripts/dartdomgenerator.py#newcode207 tools/dom/scripts/dartdomgenerator.py:207: path_to_dart = utils.DartSdkBinary() On second thought, it's probably OK ...
7 years, 11 months ago (2013-01-09 00:44:48 UTC) #3
Andrei Mouravski
This should be temporary, but in any case, the number of people running go.sh is ...
7 years, 11 months ago (2013-01-09 15:33:45 UTC) #4
blois
7 years, 11 months ago (2013-01-09 17:34:30 UTC) #5
lgtm

Discussed, looks good.

Powered by Google App Engine
This is Rietveld 408576698