Issue 11824053: Implement port equality on SendPortSync

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11824053: Implement port equality on SendPortSync (Closed)

Created:
7 years, 11 months ago by vsm

Modified:
7 years, 11 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Implement port equality on SendPortSync This should fix https://github.com/dart-lang/js-interop/issues/37 Committed: https://code.google.com/p/dart/source/detail?r=16932

Patch Set 1 #

Patch Set 2 : Move SendPortSync back to dart:isolate and regen html #

Total comments: 1

Patch Set 3 : 80 char fix #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+99 lines, -2 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	1 2	3 chunks	+19 lines, -0 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		3 chunks	+19 lines, -0 lines	0 comments	Download
M	sdk/lib/isolate/base.dart	View	1 2	1 chunk	+21 lines, -2 lines	0 comments	Download
M	tests/html/js_interop_2_test.dart	View		2 chunks	+21 lines, -0 lines	0 comments	Download
M	tools/dom/src/Isolates.dart	View	1	3 chunks	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

7 years, 11 months ago (2013-01-10 02:12:07 UTC) #2

lgtm with comment!

https://codereview.chromium.org/11824053/diff/2001/sdk/lib/isolate/base.dart
File sdk/lib/isolate/base.dart (right):

https://codereview.chromium.org/11824053/diff/2001/sdk/lib/isolate/base.dart#...
sdk/lib/isolate/base.dart:144: * a [SendPortSync] is delivered to its respective
[ReceivePortSync]. There might
80 char

Expand Messages | Collapse Messages