Make a Future returned by the action of Future.whenCompelete delay.

Make a Future returned by the action of Future.whenCompelete delay.

BUG=dartbug.com/7790

Committed: https://code.google.com/p/dart/source/detail?r=16901

[floitsch, 2013-01-09 17:10:13]

LGTM!

https://codereview.chromium.org/11824032/diff/1/sdk/lib/async/future.dart
File sdk/lib/async/future.dart (right):

https://codereview.chromium.org/11824032/diff/1/sdk/lib/async/future.dart#new...
sdk/lib/async/future.dart:108: * [:null:] (or any non-future value), its return
value is ignored.
If the [action] does not return a future its return value is ignored.

https://codereview.chromium.org/11824032/diff/1/sdk/lib/async/future.dart#new...
sdk/lib/async/future.dart:113: * If the call to [action] returns a [Future],
[:f2:], then completion  of
nit: spurious space between "completion" and "of"

https://codereview.chromium.org/11824032/diff/1/sdk/lib/async/future.dart#new...
sdk/lib/async/future.dart:114: * [:f:] is delayed until [:f2:] completes. If
[:f2:] completes with a
completes with an (remove "a").

https://codereview.chromium.org/11824032/diff/1/sdk/lib/async/future.dart#new...
sdk/lib/async/future.dart:117: Future<T> whenComplete(Future action());
Don't write the return value here. The editor will infer that you should return
something and bug people when they write functions.

https://codereview.chromium.org/11824032/diff/1/sdk/lib/async/future_impl.dart
File sdk/lib/async/future_impl.dart (right):

https://codereview.chromium.org/11824032/diff/1/sdk/lib/async/future_impl.dar...
sdk/lib/async/future_impl.dart:423: _setValue(value);P
;P ? ;)

https://codereview.chromium.org/11824032/diff/1/sdk/lib/async/future_impl.dar...
sdk/lib/async/future_impl.dart:477: Future whenComplete(Future action()) {
remove type completely.

[Lasse Reichstein Nielsen, 2013-01-10 07:02:32]

https://codereview.chromium.org/11824032/diff/1/sdk/lib/async/future.dart
File sdk/lib/async/future.dart (right):

https://codereview.chromium.org/11824032/diff/1/sdk/lib/async/future.dart#new...
sdk/lib/async/future.dart:108: * [:null:] (or any non-future value), its return
value is ignored.
On 2013/01/09 17:10:13, floitsch wrote:
> If the [action] does not return a future its return value is ignored.

Done.

https://codereview.chromium.org/11824032/diff/1/sdk/lib/async/future.dart#new...
sdk/lib/async/future.dart:113: * If the call to [action] returns a [Future],
[:f2:], then completion  of
On 2013/01/09 17:10:13, floitsch wrote:
> nit: spurious space between "completion" and "of"

Done.

https://codereview.chromium.org/11824032/diff/1/sdk/lib/async/future.dart#new...
sdk/lib/async/future.dart:114: * [:f:] is delayed until [:f2:] completes. If
[:f2:] completes with a
On 2013/01/09 17:10:13, floitsch wrote:
> completes with an (remove "a").

Done.

https://codereview.chromium.org/11824032/diff/1/sdk/lib/async/future.dart#new...
sdk/lib/async/future.dart:117: Future<T> whenComplete(Future action());
Ack. The old "returning null implicitly isn't good enough". :(

There is no good way to say "return Future or nothing".

https://codereview.chromium.org/11824032/diff/1/sdk/lib/async/future_impl.dart
File sdk/lib/async/future_impl.dart (right):

https://codereview.chromium.org/11824032/diff/1/sdk/lib/async/future_impl.dar...
sdk/lib/async/future_impl.dart:423: _setValue(value);P
;-P
Removed.

https://codereview.chromium.org/11824032/diff/1/sdk/lib/async/future_impl.dar...
sdk/lib/async/future_impl.dart:477: Future whenComplete(Future action()) {
On 2013/01/09 17:10:13, floitsch wrote:
> remove type completely.

Done.