Issue 11824024: Constant propagator should revisit phis when it visits predecessor block.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11824024: Constant propagator should revisit phis when it visits predecessor block. (Closed)

Created:
7 years, 11 months ago by Vyacheslav Egorov (Google)

Modified:
7 years, 11 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Constant propagator should revisit phis when it visits predecessor block. Phi's value depends both on its inputs and reachability of join's predecessors. Thus it is essential to revisit phi when predecessor becomes reachable. R=kmillikin@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=16847

Patch Set 1 #

Total comments: 1

Patch Set 2 : Move code into VisitGoto #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -12 lines)			Patch
M	runtime/vm/flow_graph_inliner.cc	View		4 chunks	+6 lines, -3 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1	2 chunks	+7 lines, -9 lines	0 comments	Download
A	tests/language/constant_propagation_phis_test.dart	View		1 chunk	+31 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Google)

LGTM with a small suggestion. https://codereview.chromium.org/11824024/diff/1/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://codereview.chromium.org/11824024/diff/1/runtime/vm/flow_graph_optimizer.cc#newcode3722 runtime/vm/flow_graph_optimizer.cc:3722: SetReachable(instr->successor()); It seems simpler ...

7 years, 11 months ago (2013-01-09 12:20:10 UTC) #2

Vyacheslav Egorov (Google)

7 years, 11 months ago (2013-01-09 12:25:50 UTC) #3

Thanks for the suggestion. Done.

Landing.

Expand Messages | Collapse Messages