Backport some work from sample to embedder:

Backport some work from sample to embedder:

- more sound support
- refactored extension methods
- some additional graphics functionality
- better error logging
- misc other changes
Committed: https://code.google.com/p/dart/source/detail?r=16895

[vsm, 2013-01-09 21:17:21]

https://codereview.chromium.org/11823034/diff/1/runtime/embedders/android/and...
File runtime/embedders/android/android_extension.cc (right):

https://codereview.chromium.org/11823034/diff/1/runtime/embedders/android/and...
runtime/embedders/android/android_extension.cc:68: LOGE("Argument at index %d
has non-numeric type", index);
Can we throw an exception in these cases?  I.e., Dart_ThrowException.  You can
see example usage here:
http://src.chromium.org/viewvc/multivm/trunk/webkit/Source/WebCore/bindings/d...

https://codereview.chromium.org/11823034/diff/1/runtime/embedders/android/mai...
File runtime/embedders/android/main.cc (right):

https://codereview.chromium.org/11823034/diff/1/runtime/embedders/android/mai...
runtime/embedders/android/main.cc:21: Context appContext = {
I was getting a compiler warning with this style of initialization.  Perhaps we
should just make a constructor.

https://codereview.chromium.org/11823034/diff/1/runtime/embedders/android/vm_...
File runtime/embedders/android/vm_glue.cc (right):

https://codereview.chromium.org/11823034/diff/1/runtime/embedders/android/vm_...
runtime/embedders/android/vm_glue.cc:202: // will not be true.
Don't follow.  Why would x and y be non-zero for HTML?

https://codereview.chromium.org/11823034/diff/1/runtime/embedders/android/vm_...
runtime/embedders/android/vm_glue.cc:290: // if (Dart_IsNull(h)) {
I think you want Dart_LookupFunction instead here.  Although, I'd be fine with
removing this in favor of the "Temp hack" below - doesn't seem so bad to me.  Up
to you.

[gram, 2013-01-09 22:33:28]

PTAL

https://codereview.chromium.org/11823034/diff/1/runtime/embedders/android/and...
File runtime/embedders/android/android_extension.cc (right):

https://codereview.chromium.org/11823034/diff/1/runtime/embedders/android/and...
runtime/embedders/android/android_extension.cc:68: LOGE("Argument at index %d
has non-numeric type", index);
On 2013/01/09 21:17:21, vsm wrote:
> Can we throw an exception in these cases?  I.e., Dart_ThrowException.  You can
> see example usage here:
>
http://src.chromium.org/viewvc/multivm/trunk/webkit/Source/WebCore/bindings/d...

Done.

https://codereview.chromium.org/11823034/diff/1/runtime/embedders/android/mai...
File runtime/embedders/android/main.cc (right):

https://codereview.chromium.org/11823034/diff/1/runtime/embedders/android/mai...
runtime/embedders/android/main.cc:21: Context appContext = {
On 2013/01/09 21:17:21, vsm wrote:
> I was getting a compiler warning with this style of initialization.  Perhaps
we
> should just make a constructor.

I just did field init instead.

https://codereview.chromium.org/11823034/diff/1/runtime/embedders/android/vm_...
File runtime/embedders/android/vm_glue.cc (right):

https://codereview.chromium.org/11823034/diff/1/runtime/embedders/android/vm_...
runtime/embedders/android/vm_glue.cc:202: // will not be true.
On 2013/01/09 21:17:21, vsm wrote:
> Don't follow.  Why would x and y be non-zero for HTML?

You're right. My browser based bubble app used the canvas coords on the page
here to normalize the mouse event coords to be canvas-relative, but that should
be handled beforehand so that any events to our Dart callbacks are already
canvas relative. Reverting.

https://codereview.chromium.org/11823034/diff/1/runtime/embedders/android/vm_...
runtime/embedders/android/vm_glue.cc:290: // if (Dart_IsNull(h)) {
On 2013/01/09 21:17:21, vsm wrote:
> I think you want Dart_LookupFunction instead here.  Although, I'd be fine with
> removing this in favor of the "Temp hack" below - doesn't seem so bad to me. 
Up
> to you.

I tried a few different things here, so I may have tried Dart_LookupFunction
already. IIRC there was one that worked for class methods but not top-level
functions, or something like that. For now I'll just go with the 'temp hack'.

[vsm, 2013-01-09 23:57:38]

lgtm