Unwrap AsyncErrors to find real error.

Unwrap AsyncErrors to find real error.

Committed: https://code.google.com/p/dart/source/detail?r=16825

[Bob Nystrom, 2013-01-08 22:44:08]

This works around: http://code.google.com/p/dart/issues/detail?id=7781

[nweiz, 2013-01-08 23:05:13]

A couple comments, otherwise LGTM.

https://codereview.chromium.org/11821006/diff/1/utils/pub/utils.dart
File utils/pub/utils.dart (right):

https://codereview.chromium.org/11821006/diff/1/utils/pub/utils.dart#newcode189
utils/pub/utils.dart:189: // TODO(rnystrom): Remove this when #7781 is fixed.
Nit: I usually put TODOs above dartdoc comments. I think dartdoc may not pick up
on the "///" if it's below.

https://codereview.chromium.org/11821006/diff/1/utils/pub/utils.dart#newcode191
utils/pub/utils.dart:191: while (error != null && error is AsyncError) {
"error != null" is unnecessary here. null isn't an AsyncError.

[Bob Nystrom, 2013-01-08 23:07:23]

Thanks!

https://codereview.chromium.org/11821006/diff/1/utils/pub/utils.dart
File utils/pub/utils.dart (right):

https://codereview.chromium.org/11821006/diff/1/utils/pub/utils.dart#newcode189
utils/pub/utils.dart:189: // TODO(rnystrom): Remove this when #7781 is fixed.
On 2013/01/08 23:05:13, nweiz wrote:
> Nit: I usually put TODOs above dartdoc comments. I think dartdoc may not pick
up
> on the "///" if it's below.

Done.

https://codereview.chromium.org/11821006/diff/1/utils/pub/utils.dart#newcode191
utils/pub/utils.dart:191: while (error != null && error is AsyncError) {
On 2013/01/08 23:05:13, nweiz wrote:
> "error != null" is unnecessary here. null isn't an AsyncError.

Done.