Issue 1181943002: Assert no allocation during heap iteration; fix unsafe iteration in ObjectGraph.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1181943002: Assert no allocation during heap iteration; fix unsafe iteration in ObjectGraph. (Closed)

Created:
5 years, 6 months ago by koda

Modified:
5 years, 6 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Assert no allocation during heap iteration; fix unsafe iteration in ObjectGraph. BUG=https://github.com/dart-lang/sdk/issues/21620 R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/1009d587de88ec04a66cd60409aba3a281e21f64

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -2 lines)			Patch
M	runtime/vm/heap.h	View	1 2 3 4	1 chunk	+5 lines, -2 lines	0 comments	Download
M	runtime/vm/object_graph.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/pages.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

koda

5 years, 6 months ago (2015-06-12 17:44:15 UTC) #4

Message was sent while issue was closed.

Committed patchset #5 (id:60002) manually as
1009d587de88ec04a66cd60409aba3a281e21f64 (presubmit successful).