Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(888)

Issue 11819051: Add again useVmConfiguration for deprecation purposes. This requires adding a (Closed)

Created:
7 years, 11 months ago by Siggi Cherem (dart-lang)
Modified:
7 years, 11 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add again useVmConfiguration for deprecation purposes. This requires adding a reference to the meta package fixing publish_pkg to rewrite imports correctly. Committed: https://code.google.com/p/dart/source/detail?r=16991

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M pkg/unittest/lib/vm_config.dart View 1 2 chunks +4 lines, -0 lines 0 comments Download
M pkg/unittest/pubspec.yaml View 1 1 chunk +3 lines, -1 line 0 comments Download
M tools/publish_pkg.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Siggi Cherem (dart-lang)
7 years, 11 months ago (2013-01-10 03:44:57 UTC) #1
Jennifer Messerly
lgtm
7 years, 11 months ago (2013-01-10 04:38:20 UTC) #2
Siggi Cherem (dart-lang)
PTAL - replaced with "package:" dependency now that they can be used within pkg/ packages, ...
7 years, 11 months ago (2013-01-11 19:48:10 UTC) #3
Jennifer Messerly
lebtm? -- looks even better to me :)
7 years, 11 months ago (2013-01-11 21:00:21 UTC) #4
gram
7 years, 11 months ago (2013-01-12 00:06:06 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698