Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 11819030: Add onClosed callbacks to HTTP output streams (Closed)

Created:
7 years, 11 months ago by Søren Gjesse
Modified:
7 years, 11 months ago
Reviewers:
Mads Ager (google)
CC:
reviews_dartlang.org, nweiz
Visibility:
Public.

Description

Add onClosed callbacks to HTTP output streams The onClosed will e called after the stream is closed, but the actual data might still be buffered internally. BUG=dart:7761 R=ager@google.com Committed: https://code.google.com/p/dart/source/detail?r=16860

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -6 lines) Patch
M sdk/lib/io/http_impl.dart View 8 chunks +14 lines, -6 lines 0 comments Download
A tests/standalone/io/http_stream_close_test.dart View 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Søren Gjesse
7 years, 11 months ago (2013-01-09 15:47:30 UTC) #1
Mads Ager (google)
LGTM
7 years, 11 months ago (2013-01-09 15:53:58 UTC) #2
Mads Ager (google)
Looking at the documentation of OutputStream, we explicitly say that onClosed is not called until ...
7 years, 11 months ago (2013-01-09 16:07:44 UTC) #3
Mads Ager (google)
7 years, 11 months ago (2013-01-09 16:08:02 UTC) #4
Message was sent while issue was closed.
On 2013/01/09 16:07:44, Mads Ager wrote:
> Looking at the documentation of OutputStream, we explicitly say that onClosed
is
> not called until all data has been written to the underlying communication
> channel. So maybe we should do this change after all?

shouldn't

Powered by Google App Engine
This is Rietveld 408576698