Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(976)

Issue 11818027: Change limits on slow-consumer test. (Closed)

Created:
7 years, 11 months ago by Lasse Reichstein Nielsen
Modified:
7 years, 11 months ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Change limits on slow-consumer test. The actual buffer size was too big to store in 32 MiB on a 64-bit VM. Anders: Check why the other slow-consumer tests work. TBR=ajohnsen@google.com Committed: https://code.google.com/p/dart/source/detail?r=16851

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M tests/lib/async/slow_consumer3_test.dart View 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Lasse Reichstein Nielsen
The data size sent in the slow_consumer tests is not bytes but lists entries taking ...
7 years, 11 months ago (2013-01-09 13:26:51 UTC) #1
Anders Johnsen
7 years, 11 months ago (2013-01-09 13:32:30 UTC) #2
Message was sent while issue was closed.
LGTM.

The alternative would be to use scalar lists to have full control of the sizes.

Powered by Google App Engine
This is Rietveld 408576698