Issue 11817059: Fixes for a number of dart analyzer issues in dart:html.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11817059: Fixes for a number of dart analyzer issues in dart:html. (Closed)

Created:
7 years, 11 months ago by blois

Modified:
7 years, 11 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fixes for a number of dart analyzer issues in dart:html. These are mostly just adding missing methods fixing a few typos from the experimental merge. BUG= Committed: https://code.google.com/p/dart/source/detail?r=17035

Patch Set 1 : #

Patch Set 2 : Syncing to latest. #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+502 lines, -182 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View		72 chunks	+198 lines, -73 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		72 chunks	+198 lines, -73 lines	0 comments	Download
M	sdk/lib/html/html_common/filtered_element_list.dart	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	sdk/lib/svg/dart2js/svg_dart2js.dart	View	1	12 chunks	+30 lines, -12 lines	0 comments	Download
M	sdk/lib/svg/dartium/svg_dartium.dart	View	1	12 chunks	+30 lines, -12 lines	0 comments	Download
M	tools/dom/src/CssClassSet.dart	View		1 chunk	+23 lines, -0 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Element.darttemplate	View		5 chunks	+10 lines, -7 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Node.darttemplate	View		2 chunks	+5 lines, -2 lines	0 comments	Download
M	tools/dom/templates/immutable_list_mixin.darttemplate	View		2 chunks	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

blois

This fixes most of the issues in dart:html, but it looks like a number of ...

7 years, 11 months ago (2013-01-11 01:27:03 UTC) #1

LGTM!
thanks.

Expand Messages | Collapse Messages