Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Issue 1181663004: Fix for explicit dart:core import. (Closed)

Created:
5 years, 6 months ago by scheglov
Modified:
5 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for explicit dart:core import. This fixes the rest of the co19/ tests. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/96670b0e97bfba50963eda0fb28e28c4828e5e07

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -0 lines) Patch
M pkg/analyzer/lib/src/task/dart.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/static_warning_code_test.dart View 1 chunk +11 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 2 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 6 months ago (2015-06-12 20:18:38 UTC) #1
Brian Wilkerson
LGTM
5 years, 6 months ago (2015-06-12 20:24:58 UTC) #2
scheglov
5 years, 6 months ago (2015-06-12 20:26:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
96670b0e97bfba50963eda0fb28e28c4828e5e07 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698