Issue 1181613003: Update dart2js-cps_ir test expectations with better annotations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1181613003: Update dart2js-cps_ir test expectations with better annotations. (Closed)

Created:
5 years, 6 months ago by karlklose

Modified:
5 years, 6 months ago

Reviewers:
asgerf

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Update dart2js-cps_ir test expectations with better annotations. R=asgerf@google.com Committed: https://github.com/dart-lang/sdk/commit/e4b56654ff6dc261a7fa7e16787f2dcc8cd7f8e6

Patch Set 1 #

Total comments: 1

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+436 lines, -440 lines)			Patch
M	pkg/pkg.status	View	2 chunks	+18 lines, -18 lines	0 comments	Download
M	samples/samples.status	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/benchmark_smoke/benchmark_smoke.status	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/co19/co19-dart2js.status	View	6 chunks	+78 lines, -77 lines	0 comments	Download
M	tests/compiler/dart2js_extra/dart2js_extra.status	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	tests/compiler/dart2js_native/dart2js_native.status	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/html/html.status	View	1 chunk	+143 lines, -143 lines	0 comments	Download
M	tests/isolate/isolate.status	View	2 chunks	+26 lines, -26 lines	0 comments	Download
M	tests/language/language_dart2js.status	View	16 chunks	+101 lines, -106 lines	0 comments	Download
M	tests/lib/lib.status	View	5 chunks	+38 lines, -38 lines	1 comment	Download
M	tests/standalone/standalone.status	View	3 chunks	+22 lines, -22 lines	0 comments	Download
M	tests/utils/utils.status	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

asgerf

LGTM. https://codereview.chromium.org/1181613003/diff/1/tests/lib/lib.status File tests/lib/lib.status (right): https://codereview.chromium.org/1181613003/diff/1/tests/lib/lib.status#newcode544 tests/lib/lib.status:544: mirrors/redirecting_factory_test/none: Crash # (=Class.factoryNoOptional;): Unhandled node I'll take ...

5 years, 6 months ago (2015-06-11 08:21:53 UTC) #2

karlklose

5 years, 6 months ago (2015-06-11 08:57:01 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e4b56654ff6dc261a7fa7e16787f2dcc8cd7f8e6 (presubmit successful).

Expand Messages | Collapse Messages